Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • YARR YARR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • YARR
  • YARRYARR
  • Issues
  • #68

Closed
Open
Created Aug 27, 2020 by Mario Gonzalez Carpintero@mariog

Threshold distrubutions shifted ~40e from the target threshold

We have been observing an offset of ~40 e when tuning the threshold on the differential FE (sorry, I haven't tried any other FE yet). This seems to be due to the fact that m_vcalPar[0] is used when converting Vcal to charge in Rd53aCfg::toCharge, but it's not used when doing the opposite, in Rd53aCfg::toVcal.

I wonder if there's a specific reason for this mismatch. Changing this line in Rd53aCfg::toVcal:

unsigned vcal = (unsigned) round((V)/(m_vcalPar[1]*Unit::Milli)); // Note: no offset applied

to

unsigned vcal = (unsigned) round((V - m_vcalPar[0]*Unit::Milli)/(m_vcalPar[1]*Unit::Milli));

seems to be enough to "fix" this issue.

Assignee
Assign to
Time tracking