Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • YARR YARR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • YARR
  • YARRYARR
  • Issues
  • #88

Closed
Open
Created Dec 23, 2020 by Daniel Joseph Antrim@dantrimDeveloper

Make FrontEnds have a reset mask function

What

In scanConsole there are at least a few points where very specific if FE is type <foo> blocks that require very particular handling of specific front-ends. This is not desirable. For example, in the reset-masks block here.

Proposal

It is probably better to just define a resetMasks() method to the FrontEnd base class. Then this block in scanConsole would just become:

if (mask_opt == 1) {
    for(FrontEnd* fe : bookie.feList) {
        fe->resetMasks();
    }
}

Using <algorithm> could reduce it all to a single line, as well.

With the above proposal, we move further towards making things under libYarr not be specific to a given front-end, enabling YARR to be compiled wihtout having to compile for all possible target front-ends (since currently scanConsole includes specific FrontEnds). Front-end specific things should be under lib<FrontEndType>.

Edited Dec 23, 2020 by Daniel Joseph Antrim
Assignee
Assign to
Time tracking