Skip to content

Fixing compiling error in Apple LLVM version 9.0.0

Hideyuki Oide requested to merge bugfix-compilation-20180508 into devel

The released master branch didn't compile with LLVM 9.0.0 out of the box.

libFei4/include/Fei4.h:88:14: error: 'setInjCharge' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        void setInjCharge(double charge, bool use_sCap=true, bool use_lCap=true) {
             ^
libYarr/include/FrontEnd.h:39:22: note: overridden virtual function is here
        virtual void setInjCharge(double, bool, bool) = 0;

It looks fixing was quite trivial by adding override tag properly (I also added final because the function not supposed to be inherited, by missing virtual).

Merge request reports