Skip to content

Code quality scan fixes for libStar and libStarEmu

Ryan Quinn requested to merge rquinn/YARR:fix-libstar-code-quality into devel

Had a look at the output of the code quality scans and the issues in libStar and libStarEmu were easy enough to fix so I went ahead and did so. The fixes fell into a few main categories:

  • explicit instantiation of e.g. nullptr, zero integers and arrays
  • using const references where possible
  • using std::vector::data() instead of &vector[0]
  • using using instead of typedef

No changes were made to anything that would affect the behaviour of the code.

@ztao you may be interested in this.

Edited by Ryan Quinn

Merge request reports