Skip to content

Revert "Merge branch 'feature-NXCALS-4536-support-for-fills-in-thin-api' into 'develop'"

Piotr Sowinski requested to merge revert-f677310d into develop

Merge request template

COMPATIBILITY NOTE

Please make sure that this change is BACKWARDS COMPATIBLE and a new server will work correctly with clients using old APIs versions.

It may be that data sent in the new format will break the old clients.

In case of any potential incompatibility we have to inform our clients and schedule release & deployment with them.


@acc-logging-team - please have a look for approval.

Still getting: 19:22:43 Executing test [cern.nxcals.integrationtests.extraction.thin.ThinFillTest].shouldGetFillsData() with result: FAILURE 19:22:43
19:22:43 ThinFillTest > shouldGetFillsData() FAILED 19:22:43 org.opentest4j.AssertionFailedError: expected: but was: 19:22:43 at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) 19:22:43 at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40) 19:22:43 at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) 19:22:43 at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:162) 19:22:43 at cern.nxcals.integrationtests.extraction.thin.ThinFillTest.shouldGetFillsData(ThinFillTest.java:313) 19:22:43
19:22:43 ThinFillTest > shouldGetLastCompletedData() STANDARD_OUT

Executing test [cern.nxcals.integrationtests.extraction.thin.ThinFillTest].shouldGetLastCompletedData() with result: FAILURE 19:22:58
19:22:58 ThinFillTest > shouldGetLastCompletedData() FAILED 19:22:58 org.opentest4j.AssertionFailedError: expected: but was: 19:22:58 at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) 19:22:58 at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40) 19:22:58 at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) 19:22:58 at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:162) 19:22:58 at cern.nxcals.integrationtests.extraction.thin.ThinFillTest.shouldGetLastCompletedData(ThinFillTest.java:325) 19:22:58
19:22:58 ThinFillTest > shouldGetFillData() STANDARD_OUT

19:23:01 ThinFillTest > shouldGetFillData() FAILED 19:23:01 org.opentest4j.AssertionFailedError: expected: <2> but was: <0> 19:23:01 at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) 19:23:01 at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) 19:23:01 at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) 19:23:01 at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145) 19:23:01 at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:510) 19:23:01 at cern.nxcals.integrationtests.extraction.thin.ThinFillTest.shouldGetFillData(ThinFillTest.java:295) 19:23:01
19:23:01 ThinExtractionTest STANDARD_OUT

Merge request reports