fix wrong consistency checks

Core/include/Acts/Geometry/CuboidVolumeBounds.hpp

@@ -159,7 +159,8 @@ inline std::vector<double> CuboidVolumeBounds::values() const {
 }
 
 inline void CuboidVolumeBounds::checkConsistency() noexcept(false) {
-  if (get(eHalfLengthX) * get(eHalfLengthY) * get(eHalfLengthZ) <= 0.) {
+  if (get(eHalfLengthX) <= 0 or get(eHalfLengthY) <= 0 or
+      get(eHalfLengthZ) <= 0.) {
     throw std::invalid_argument(
         "CuboidVolumeBounds: invalid input, zero or negative.");
   }

Tests/UnitTests/Core/Geometry/CuboidVolumeBoundsTests.cpp

@@ -47,12 +47,18 @@ BOOST_AUTO_TEST_CASE(CuboidVolumeRecreation) {
 BOOST_AUTO_TEST_CASE(CuboidVolumeException) {
   // Test exception negative x
   BOOST_CHECK_THROW(CuboidVolumeBounds(-hx, hy, hz), std::logic_error);
-
   // Test exception negative y
   BOOST_CHECK_THROW(CuboidVolumeBounds(hx, -hy, hz), std::logic_error);
-
   // Test exception negative z
   BOOST_CHECK_THROW(CuboidVolumeBounds(hx, hy, -hz), std::logic_error);
+  // Other iterations 0
+  BOOST_CHECK_THROW(CuboidVolumeBounds(-hx, hy, -hz), std::logic_error);
+  // Other iterations 1
+  BOOST_CHECK_THROW(CuboidVolumeBounds(-hx, -hy, hz), std::logic_error);
+  // Other iterations 2
+  BOOST_CHECK_THROW(CuboidVolumeBounds(hx, -hy, -hz), std::logic_error);
+  // Other iterations : all
+  BOOST_CHECK_THROW(CuboidVolumeBounds(-hx, -hy, -hz), std::logic_error);
 }
 
 BOOST_AUTO_TEST_CASE(CuboidVolumeProperties) {