WIP: Add getter for measurement covariance
Fixes ACTS-305.
The proposed implementation is general in that it uses dynamic matrices, which comes at the expense of some performance. However, in the foreseen usecases (mainly debugging) this should not matter too much.
Merge request reports
Closed by
(Mar 10, 2025 12:27pm UTC)
Activity
Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp-
Results available at: Jenkins [ACTS-MERGE #201]
-
Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp -
test coverage result:
Overall coverage rate:
lines......: 33.9% (2844 of 8392 lines)
functions..: 45.2% (1034 of 2288 functions)
full test results can be found here -
doxygen output:
0 errors
57 warnings
full doxygen output can be found here -
Results available at: Jenkins [ACTS-MERGE #202]
383 : public boost::static_visitor<const Eigen::Matrix<double, 384 Eigen::Dynamic, 385 Eigen::Dynamic>> 386 { 387 public: 388 template <typename Meas_t> 389 const Eigen::Matrix<double, Eigen::Dynamic, Eigen::Dynamic> 390 operator()(const Meas_t& m) const 391 { 392 return m.covariance(); 393 // return CovMatrix_t(); 394 } 395 }; 396 397 template <BOOST_VARIANT_ENUM_PARAMS(typename T)> 398 const Eigen::Matrix<double, Eigen::Dynamic, Eigen::Dynamic> added 3 commits
- c107f358 - Remove forgotten comment
- 9a0283f0 - Add comment on matrix copies
- f0e8eddc - Merge branch 'Add_CovarianceGetter' of ssh://gitlab.cern.ch:7999/vavolkl/a-commo…
-
Results available at: Jenkins [ACTS-MERGE #233]
-
Results available at: Jenkins [ACTS-MERGE #234]
-
Results available at: Jenkins [ACTS-MERGE #237]
