Introducing confined volume logic for TrackingVolume and DD4hep
Using the extension architecture from ACTS-534 the propagation through a muon system which involves confined volumes can be implemented. The confined volumes are be treated as floating objects like a module of MDTs in ATLAS. Besides a first Acts implementation, this MR includes adds a structure to perform a translation of confined volumes in DD4hep into Acts
Closes ACTS-536
Merge request reports
Activity
added 13 commits
-
5da45998 - 1 commit from branch
ACTS-513
- ac11886b - Fixed unit tests
- df211198 - Replaced detector in unit test
- 8555117d - Modified maxsteps
- 63c01234 - Builder for confined volumes added
- daf45037 - Added full boundary resolving
- 2708adbb - Boundary connections added
- bb2d83e6 - Fixed unit test; removed couts
- 988d14ce - Edge case test added
- 3953e260 - Edge case tests
- caaa2309 - First draft of EigenStepper geometry
- 445329b9 - tmp
- bf4b8dae - Full box detector test for stepper added
Toggle commit list-
5da45998 - 1 commit from branch
For job clang_tidy on commit: 40469064
Static analysis results: Failed
ok pattern count limit readability-inconsistent-declaration-parameter-name
1 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
3 0 modernize-use-override
0 0 readability-implicit-bool-cast
4 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
2 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
For job clang_tidy on commit: 3f1028ee
Static analysis results: Failed
ok pattern count limit readability-inconsistent-declaration-parameter-name
1 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
0 0 modernize-use-override
0 0 readability-implicit-bool-cast
0 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
0 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
For job clang_tidy on commit: 8475172b
Static analysis results: Accepted
ok pattern count limit readability-inconsistent-declaration-parameter-name
0 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
0 0 modernize-use-override
0 0 readability-implicit-bool-cast
0 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
0 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
added 334 commits
-
8475172b...8759b07d - 308 commits from branch
ACTS-513
- 5bf56826 - Added collection of all possible boundary surfaces in TrackingVolume
- a7376ef6 - Sorting of boundary surfaces templated for TrackingVolume
- a8f83dd6 - MR comments
- 3ff9037a - Auctioneer setting in EigenStepper added; Covariance test for test cases a&b in unit test added
- 66ddec2e - tmp store
- dc18a637 - unit & integration tests work
- a2b1042d - Re-enabled other integration tests
- 18a30337 - Wrongly set * removed, step size adjustment fixed
- 39b3a311 - Format fixed
- 5bcc9ee7 - Debugged cov!
- a8027b46 - Removed recreation of detector parts
- 94580595 - Fixed unit tests
- d897ab97 - Replaced detector in unit test
- 45fc882c - Modified maxsteps
- a004925f - Builder for confined volumes added
- e97446ca - Added full boundary resolving
- c209256e - Boundary connections added
- a2f181a4 - Fixed unit test; removed couts
- d100dfdb - Edge case test added
- 53215a6b - Edge case tests
- b8425dd0 - First draft of EigenStepper geometry
- 0b53b54d - tmp
- c09fbd2b - Full box detector test for stepper added
- 37342225 - clang tidy
- 726a671a - clang
- 097a4e32 - Rebase
Toggle commit list-
8475172b...8759b07d - 308 commits from branch
For job clang_tidy on commit: 862e654c
Static analysis results: Accepted
ok pattern count limit readability-inconsistent-declaration-parameter-name
0 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
0 0 modernize-use-override
0 0 readability-implicit-bool-cast
0 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
0 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
added 9 commits
Toggle commit listFor job clang_tidy on commit: d1b32f8d
Static analysis results: Failed
ok pattern count limit readability-inconsistent-declaration-parameter-name
0 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
1 0 modernize-use-override
0 0 readability-implicit-bool-cast
0 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
0 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
For job clang_tidy on commit: b19b646c
Static analysis results: Accepted
ok pattern count limit readability-inconsistent-declaration-parameter-name
0 0 readability-named-parameter
0 0 readability-container-size-empty
0 0 modernize-use-using
0 0 readability-braces-around-statements
0 0 modernize-use-override
0 0 readability-implicit-bool-cast
0 0 modernize-use-default-member-init
0 0 performance-unnecessary-value-param
0 0 modernize-use-equals-default
0 0 modernize-use-nullptr
0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/488/clang_tidy
mentioned in merge request !473 (merged)
added 459 commits
-
b19b646c...82a246ac - 384 commits from branch
master
- 79c2d7e7 - Detector construction built
- 5143a2bb - Retry for navigator after break added
- 06301a26 - Detector for step size restriction added
- 3643fbdf - Added collection of all possible boundary surfaces in TrackingVolume
- db506bbe - Sorting of boundary surfaces templated for TrackingVolume
- 889b2fd5 - BB in SI implemented, still quite rough interactions
- a5c617da - Changed Sorter name and location
- f4107241 - constexpr landau2gauss -> const
- 8e5be2fa - Moved test to Propagator/
- 6072c4c3 - tmp
- d468f1f9 - Fixed MaterialCollection bug with EigenStepper
- b0ee78f5 - Fixed unit tests
- 8f7955d9 - tmp store
- ff7aafd4 - unit & integration tests work
- 7ad1c4c6 - tmp storage for debugging
- a8e1d52e - Wrongly set * removed, step size adjustment fixed
- dc9c0fcf - Clean up
- b2a21144 - MR comments implemented
- 3c4290b8 - MR comments
- 6c3942ae - Changed binning to float
- 50937841 - State -> propagator_state_t
- 2928fedd - Sorting of boundary surfaces templated for TrackingVolume
- 222ea834 - tmp store
- b51b624f - unit & integration tests work
- 2650e51e - Fixed unit tests
- 2d94a515 - Surfaces changed to sensitive
- 4ba74e05 - Replaced detector in unit test
- e28cf4fa - Debugged cov!
- 4e1a22c4 - Removed recreation of detector parts
- c043c0c4 - tmp
- 30633f72 - Building config structure in progress
- a748e492 - Tests for surfaces expanded & for layers added
- 8328cedd - TrackingGeometry building added
- a70a0799 - Removed multiple binning directions
- ce518a5f - Removed recreation of detector parts
- ab2c2433 - MR comments
- 8ee5ed4c - rebase
- a3c31936 - SurfaceArrayCreater for planes
- 1d253b1b - Binning direction variation
- 0f0d004e - Compiling version with trackingGeometry()
- 006cbe5c - Sorting of boundary surfaces templated for TrackingVolume
- 89bc6fb0 - Auctioneer setting in EigenStepper added; Covariance test for test cases a&b in unit test added
- bb06b664 - tmp store
- 2b42cf0b - unit & integration tests work
- 00fa2562 - Re-enabled other integration tests
- fcf35952 - Wrongly set * removed, step size adjustment fixed
- 49fa0861 - Format fixed
- 900c2630 - Debugged cov!
- c8dcf0cc - Removed recreation of detector parts
- b98fd923 - Replaced detector in unit test
- 21a72a39 - Modified maxsteps
- ebc46c1d - Builder for confined volumes added
- fe238310 - Added full boundary resolving
- 5a09f43c - Boundary connections added
- 96c3c218 - Fixed unit test; removed couts
- 717c5f73 - Edge case test added
- 2c6149ff - Edge case tests
- 7a74f2d7 - First draft of EigenStepper geometry
- 06b83563 - tmp
- f23be296 - Full box detector test for stepper added
- 62bbf536 - clang tidy
- 2945be58 - clang
- e893dd74 - Rebase
- 4c6ae814 - Format
- c6088097 - First draft for dd4hep volume conversion
- 44b0e87a - Draft moved further to production facility
- 2d37856d - Comments added
- 51cd6033 - Starting putting together
- 793377f6 - tmp
- d2a0a7a4 - tmp
- 7fd4327c - tmp
- a6231912 - First draft complete
- be2a5211 - Format fixed
- 8dd33d2b - clang
- 6cf529a4 - Rebase
Toggle commit list-
b19b646c...82a246ac - 384 commits from branch