Resolve "Free parameter input/output for stepper" - part 1.5

added Improvement label

Considers is not a keyword for gitlab. Please use Fixes or Closes if it does either of them, or just mention the issue.

changed title from Resolve "Free parameter input/output for stepper" to Resolve "Free parameter input/output for stepper" - part 1.5

changed the description

@fklimpel As mentioned already in !651 (merged), I do not understand why this is a new MR? This only removes code that would be added after merging the !651 (merged) to begin with. Why not update the original MR to not include the changes in the first place? You could use git revert to remove changes introduced in previous commits; or even better use interactive rebase to remove the changes completely so they do not appear in !651 (merged) in the first place.

Where is the difference in the end? If this one is merged then !651 (merged) is exactly the same with the only difference that it is possible by now to see the changes and to keep the MRs small enough

But why a second MR just to undo changes that will be introduced with an MR that has not been merged yet. That is not good development practice. A MR should be a meaningful unit of change. This is not.

@fklimpel @asalzbur Can we come to a conclusion on this? I would strongly prefer this changes to be added to the original MR !651 (merged) so we do not add unnecessary changes and can get the minimal functionality in that we want.

The MR should points to !651 (merged), so the changes will be added to the other MR if merged. Where is the problem with it?

Its unnecessary. We concluded in !651 (merged) that we do not need the extra inheritance hierarchy so !651 (merged) should be changed directly. We keep all comments on the same subject in the same MR and can review all changes at a single place.

!651 (merged) followed our current design of an inheritance based structure for the different parametrisations. As soon as we break up the inheritance relation between the different types. Therefore we need (or better should) change a couple more things. So this MR treats a whole different situation than the small change intended in !651 (merged)