Simplify the GeometryID interface (w/o introducing MultiIndex)

• Add explicit getters and setters for the GeometryID components.
• Remove unused/unnecessary GeometryID operators, i.e. only operator< and operator== are really necessary.
• Implement bit coding as constexpr ... functions and remove unused macros.

Fixes #654 (closed) and #655 (closed).

This is !683 (closed) with just the GeometryID interface changes and no MultiIndex.

changed milestone to %0.12.00

added Improvement Minor labels

mentioned in merge request !683 (closed)

added 2 commits

• 7e0b1941 - Tests: rewrite GeometryID tests and move them to correct location
• 1d381e49 - Helpers: remove unused bit coding macros

Compare with previous version

added 1 commit

• c8f6ef8a - GeometryID: implement clang-tidy recommendations

Compare with previous version

I think I’m happy with this. Are you sure that the constexpr helpers are expanded at compile time, and don’t result in an additional function call? That would be the only change that I’m a bit skeptical of.

I agree, that looks good to me too. @msmk can you comment on Paul's question?

Godbolt thinks so. Everything is optimized away to give you the effective value directly.

Sounds good, then.

approved this merge request

mentioned in commit 0f35558e

merged

changed milestone to %0.11.00

mentioned in merge request !717 (merged)

mentioned in merge request atlas/atlasexternals!579 (merged)