OversteppingLimit and pathLimit setting
Closes #672 (closed)
This MR concludes the shift to the new intersect(...)
method:
- the last path/limit settings are moved from the
Navigator
to theStepper
. This prepares for theMultiComponentStepper
- it harmonises the
updateSurfaceStatus(...)
, i.e. it lets theStepper
decide how to set the step estimation to a surface - it moves the
releaseStep()
to theStepper
itself - it moves the public API of
ConstrainedStep
out of thedetail
namespace - it fixes the
LoopCorrection
to know about negative path lengths - adapts the
StepperConcept
for this. - it finally removes the HACK code (which becomes dead code, tested on 5*10^6 tracks) :
// @HOTFIX to break the RK step trying, @TODO will be replaced
// by proper overstepping mechanism
if (++stepAttempts == 100) {
// step in mm steps, costly but should do
state.stepping.stepSize = state.stepping.navDir * 1_mm;
break;
}
This MR also fixes the problem of potential loops (still present in the GenericDetector examples), this is an example of pT = 50 MeV
tracks with full loop protection.
With this MR, mu~200
fatras simulation will run finally at Hz level:
Edited by Andreas Salzburger
Merge request reports
Activity
Filter activity
changed milestone to %0.12.00
added 14 commits
-
59680948...14fd7b45 - 5 commits from branch
master
- 1add3468 - added SurfaceIntersectionBenchmark and opimise PlaneSurface::intersect(...)
- 09c0d914 - fix clang-format
- bbd896fe - clang-format fix
- b724e67d - added some tilt to the test surface
- 1f2c46f5 - fixing unit test
- c3f08742 - CylinderSurface
- b1168a14 - LineSurface fix
- 34fabde5 - introduce SteppingHelper.ipp
- e730b616 - First replacement
Toggle commit list-
59680948...14fd7b45 - 5 commits from branch
added 1 commit
- b7ba6d8c - miniminze the access to state.stepping in Navigator
assigned to @asalzbur
added 85 commits
-
cb24b599...7b8e9250 - 71 commits from branch
master
- cba5b794 - added SurfaceIntersectionBenchmark and opimise PlaneSurface::intersect(...)
- 98daf51c - fix clang-format
- 46857474 - clang-format fix
- 28d2f855 - added some tilt to the test surface
- e751c67e - fixing unit test
- 5067090d - CylinderSurface
- a06916a6 - LineSurface fix
- c93a9434 - addressing MR comments, restrict fast BoundsCheck() to eAbsolute
- b31e3d06 - use eLOC_Z
- 99a2e6fd - introduce SteppingHelper.ipp
- 149d0e3c - First replacement
- 2ab61598 - miniminze the access to state.stepping in Navigator
- dc760ae4 - fix part of the unit tests
- 4cf1e991 - fix unit test, KF test now failing
Toggle commit list-
cb24b599...7b8e9250 - 71 commits from branch
added 33 commits
Toggle commit list- Resolved by Andreas Salzburger
- Resolved by Andreas Salzburger
Please register or sign in to reply