Skip to content
Snippets Groups Projects

Implement KF with backward filtering

Merged Xiaocong Ai requested to merge 682-implement-kf-smoothing-as-backward-filtering into master

This MR (Closes #682 (closed)) implements the option to run KF fit in forward filtering + backward filtering mode in addition to the current forward filtering + smoothing with formalism.

  • In the forward filtering + backward filtering mode:
  1. After forward filtering is done, the propagation direction is reversed and navigation and stepping state are updated to last measurement state.
  2. The 'smoothed' parameter is taken as the filtered parameter in the backward filtering. If the backward filtering misses some surfaces in the forward filtering, then there is no smoothed parameter for the state on this surface.
  • The material interactor is changed to allow for navigation-independent covariance update (now in default always add noise)

The performance of KF in this mode could be found here:KF_Jan13_2020.pdf

A timing test for the two KF modes with the Generic Detector geometry and ATLAS B field could be found here:KF_timing_test

Edited by Xiaocong Ai

Merge request reports

Pipeline #1404403 passed

Pipeline passed for 2bcb0854 on 682-implement-kf-smoothing-as-backward-filtering

Test coverage 65.00% (0.00%) from 1 job

Merged by Andreas SalzburgerAndreas Salzburger 5 years ago (Feb 11, 2020 3:59pm UTC)

Loading

Pipeline #1406690 passed

Pipeline passed for 765d3e46 on master

Test coverage 65.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ok, I'm personally not a big fan of how the final merging of the results for forward and backward states works, with the map you added. This is necessary because we might miss a surface on the way back that hit on the way forward, or the other way around?

    Apart from that (and this is not really due to the specific changes of this MR), I feel like the KF has reached the amount of complexity we can shove in there before it becomes hard to follow what's going on. The sequence of transitions in the implicit FSM here is pretty convoluted now and depends on a lot of parameters.

    Edited by Paul Gessinger
  • Author Developer

    You're right. The forward and backward propagation could have different propagation path, thus different surfaces. But as said above, we don't have to use the additional map if we want to keep the kalman fitter result as tidy as possible.

    I still need a take a further look at the FSM to understand it better. But I'm quite happy to switch FSM-based KF if it helps. We could discuss this next year.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading