Improvements for TGeo geometry binding
Closes #685 (closed)
This MR adds new functionality to the TGeoPlugin
to allow more detector setups. There are a few necessary adaptions in the Core/Geometry
module, particularly concerning ring layouts and layer splitting.
It adds:
- automated detection of layer splitting (if configured to do so)
- automated detection or end-cap ring layout (if configured to do so)
-
AnnulusBounds
for DiscSurfaces - updates the
ObjWriter
for AnnulusBounds - introduces interface for IdentifierProvider
It will allow to build the silicon part of:
- sPhenix
- ATLAS ITk
- CMS
Edited by Andreas Salzburger
Merge request reports
Activity
Filter activity
added 1 commit
- 3c81d8d6 - introduce AnnulusBounds, first Obj writing version (rudimentory)
ATLAS ITk can now be built with
AnnulusBounds
with the following command:ACTFWTGeoGeometryExample -n1 -l0 --geo-tgeo-filename ITk.root --geo-tgeo-worldvolume ITK_1 --geo-tgeo-bp-parameters 26. 3000. 0.8 --geo-tgeo-ringlayout 0 1 0 --geo-tgeo-ringtolerance 0. 5. 0. --geo-tgeo-nlayers 1 1 1 --geo-tgeo-clayers 1 1 1 --geo-tgeo-players 1 1 1 --geo-tgeo-nlayer-rmin 0. 135. 0. --geo-tgeo-clayer-rmin 0. 135. 350. --geo-tgeo-player-rmin 0. 135. 0. --geo-tgeo-nlayer-rmax 135. 350. 1200. --geo-tgeo-clayer-rmax 135. 350. 1200. --geo-tgeo-player-rmax 135. 350. 1200. --geo-tgeo-nlayernames Pixel::ECLayer Pixel::ECLayer SCT_ForwardMinus --geo-tgeo-clayernames Pixel::Layer Pixel::Layer SCT_Barrel --geo-tgeo-playernames Pixel::ECLayer Pixel::ECLayer SCT_ForwardPlus --geo-tgeo-nmodulenames SensorBrl SensorBrl ECSensor --geo-tgeo-cmodulenames SensorBrl SensorBrl BRLSensor --geo-tgeo-pmodulenames SensorBrl SensorBrl ECSensor --geo-tgeo-nmoduleaxes yzx yzx xyz --geo-tgeo-cmoduleaxes yzx yzx xyz --geo-tgeo-pmoduleaxes yzx yzx xyz --geo-tgeo-nlayer-rsplit 0. 15. 0. --geo-tgeo-nlayer-zsplit 10. 20. 35. --geo-tgeo-clayer-rsplit 25. 25. 35. --geo-tgeo-clayer-zsplit 0. 0. 0. --geo-tgeo-player-rsplit 0. 15. 0. --geo-tgeo-player-zsplit 10. 20. 35. --geo-subdetectors BeamPipe InnerPixels OuterPixels Strips --geo-surface-loglevel 2 --geo-layer-loglevel 2 --geo-volume-loglevel 2 --output-obj true
Edited by Andreas Salzburgeradded 86 commits
-
1329a9df...15c6dc80 - 74 commits from branch
master
- a3bcc35b - central layer splitting enabled
- 89be2601 - update to split deduction
- 4b5dfb2b - introduce layer splitting in TGeoLayerBuilder
- 4aa80ea4 - first adaptions tio ring layout
- 37b7ab3c - split detection works, sorting missing
- ad405358 - introduce AnnulusBounds, first Obj writing version (rudimentory)
- 021a539c - full ITk built
- 6636bb3f - fix licence statement
- 0831e134 - fix clang-tidy warnings
- c7b3b55e - clang-format fix
- 4cf1f730 - fix locpo name error
- 3c1b1346 - ab
Toggle commit list-
1329a9df...15c6dc80 - 74 commits from branch
added 32 commits
-
02556058...69b18dce - 17 commits from branch
master
- a2681d60 - central layer splitting enabled
- 77eaeb6e - update to split deduction
- 7582511a - introduce layer splitting in TGeoLayerBuilder
- d3276189 - first adaptions tio ring layout
- 8549b283 - split detection works, sorting missing
- b34d08d1 - introduce AnnulusBounds, first Obj writing version (rudimentory)
- ed0ad019 - full ITk built
- 6765e4b9 - fix licence statement
- 2ff27152 - fix clang-tidy warnings
- b3c7bb47 - clang-format fix
- b1809b26 - fix locpo name error
- 499dfdc5 - ab
- d5fc5577 - introduce identifier system
- 3f07a050 - adding IdentifierSvc
- c1a81231 - adding UnitTest for AnnulusBounds
Toggle commit list-
02556058...69b18dce - 17 commits from branch
added 19 commits
-
8f4e437c...e0f06c03 - 3 commits from branch
master
- 4c9f7657 - central layer splitting enabled
- 520a3cd0 - update to split deduction
- 7b8f73c7 - introduce layer splitting in TGeoLayerBuilder
- 954eec17 - first adaptions tio ring layout
- c856e2ea - split detection works, sorting missing
- 5c289894 - introduce AnnulusBounds, first Obj writing version (rudimentory)
- d649f376 - full ITk built
- 4a1be1da - fix licence statement
- 30527ac2 - fix clang-tidy warnings
- 5c3a8083 - clang-format fix
- 02f435c0 - fix locpo name error
- d8217aca - ab
- 10a629be - introduce identifier system
- 4c431126 - adding IdentifierSvc
- e81ae892 - adding UnitTest for AnnulusBounds
- 628467d8 - moving AnnulusBoundsTests into place
Toggle commit list-
8f4e437c...e0f06c03 - 3 commits from branch
Please register or sign in to reply