Skip to content
Snippets Groups Projects

Import Fatras

Merged Moritz Kiehn requested to merge import_fatras into master
All threads resolved!

This imports the current master from acts-fatras into the Fatras directory. To keep this separate from the core plugins the include files are located in ActsFatras/ and all code is in the ActsFatras namespace. Tests are available in the Tests/UnitTests/Fatras directory.

The outstanding issues for Fatras will be moved to the core repository once this has been merge (contrary to previous plans of fixing all issues first).

Contains some small modifications to simplify adding unit/integration tests with additional libraries.

Preparation for #686.

Edited by Moritz Kiehn

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think I'm ok with this.

  • Another question: FATRAS unit tests coverage is not included. I think this is because we disable it in the coverage exclusion patterns. This is also the case with the plugins. Maybe we need to devise a way how cmake can communicate which plugins are enabled, and those plugins and their tests are then taken into account in the coverage calculation.

    Hm, maybe it isn't.

    Edited by Paul Gessinger
  • In any case, the CI should build FATRAS.

  • Author Contributor

    I will enable it in the CI build.

  • Moritz Kiehn added 2 commits

    added 2 commits

    Compare with previous version

  • Moritz Kiehn added 3 commits

    added 3 commits

    • 8f54ec3d - cmake: reorder options for clarity
    • 7c997800 - update README and getting started
    • 4cf8357f - ci: build fatras

    Compare with previous version

  • Author Contributor

    The CI should now build Fatras as well. Some of the tests fail and I will have to look into that. I do not think I will have time for that today.

    Edited by Moritz Kiehn
  • Moritz Kiehn added 13 commits

    added 13 commits

    Compare with previous version

  • assigned to @pagessin

  • Paul Gessinger resolved all threads

    resolved all threads

  • Paul Gessinger approved this merge request

    approved this merge request

  • Paul Gessinger enabled an automatic merge when the pipeline for 8c2c5468 succeeds

    enabled an automatic merge when the pipeline for 8c2c5468 succeeds

  • Paul Gessinger mentioned in commit f8a3c0f7

    mentioned in commit f8a3c0f7

  • mentioned in merge request acts-framework!203 (merged)

  • Please register or sign in to reply
    Loading