Include patch to enable build on clang+libstdc++

@akraszna added a patch in the externals a while ago to make Acts build on the clang+libstdc++ build that they're rolling. We use a custom Ubuntu image which builds on clang+libc++ specifically to avoid this issue.

Officially, as far as I know, building with the combination this ATLAS build does is not supported, but I guess there's no harm in upstreaming the patch to make life a bit easier. Let's see how this affects our CI.

changed milestone to %0.16.00

added Improvement label

marked as a Work In Progress

changed the description

added 1 commit

• af4881ce - move workaround to separate header file

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• 48068b56 - Move workaround up

Compare with previous version

Is the build failure expected?

Not really. This is run by the ATLAS build, but only in the combination clang+libstdc++, and not libc++ like here. Maybe we need to wrap it in a preprocessor guard. I'll have a look.

added 9 commits

• 48068b56...404a6024 - 6 commits from branch master
• 060b4161 - Include patch to enable build on clang+libstdc++
• 1914c67f - move workaround to separate header file
• 78f953c6 - Move workaround up

Compare with previous version

added 4 commits

• d9649804 - Include patch to enable build on clang+libstdc++
• bb7bd5f7 - move workaround to separate header file
• df1f287d - Move workaround up
• e59acc80 - only include workaround on libstdc++

Compare with previous version

I try to detect libc++ now. No idea whether this now still achieves what it's supposed to in the ATLAS build on clang+libstdc++

Doesn't seem to work in the CI :/

approved this merge request

added 12 commits

• e59acc80...f8a3c0f7 - 8 commits from branch master
• fb4b5c3d - Include patch to enable build on clang+libstdc++
• c361b04e - move workaround to separate header file
• fcebf531 - Move workaround up
• 309ba199 - only include workaround on libstdc++

Compare with previous version

enabled an automatic merge when the pipeline for 309ba199 succeeds

marked as a Work In Progress

Oh sorry, was not clear to me that this is still WIP

aborted the automatic merge because target branch was updated

I had thought it would work. I marked it WIP again because I need to figure out how do this right. Sorry for the confusion.