Skip to content
Snippets Groups Projects

Always use 3d scattering for simulation

Merged Moritz Kiehn requested to merge fatras_one_scattering into master

Remove the buggy parametric scattering simulation and always use the proper 3d scattering method.

Adds two helper methods to construct curvilinear units vectors to the Core. These were extracted from the scattering code and I suspect that similar code exists in other places too. For now the extracted helpers are only used in the scattering simulation but might be useful elsewhere in the future.

Merge request reports

Pipeline #1425213 passed

Pipeline passed for 9d382477 on fatras_one_scattering

Test coverage 65.00% (0.00%) from 1 job

Merged by Andreas SalzburgerAndreas Salzburger 5 years ago (Feb 18, 2020 4:16pm UTC)

Loading

Pipeline #1425632 passed

Pipeline passed for c9254d5a on master

Test coverage 65.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading