Only test benchmark tools if benchmarking is enabled
All threads resolved!
All threads resolved!
There are two reasons to do this:
- Benchmark optimization barriers use nonstandard constructs which, although widely portable, are not portable to every C++ compiler. The only known example is that MSVC doesn't like them. That was part of the rationale for putting benchmarks behind their own CMake flag, but this measure unfortunately falls apart if benchmarks come back through the unit test backdoor.
- Benchmark tools use
std::is_invokable_v
in a way which triggers an LLVM 7.0 bug, and that breaks the builds of all of our Mac users who haven't upgraded to XCode 11 yet. We don't want to introduce code workarounds for old compilers, but requesting a compiler upgrade just because of this component is arguably a bit much when it isn't even used.
Edited by Hadrien Benjamin Grasland
Merge request reports
Activity
Filter activity
changed milestone to %0.17.00
added Bug Component - Core Minor labels
- Resolved by Hadrien Benjamin Grasland
Instead of separating these tests with a manual flag, could we move them to the
Tests/Benchmarks
directory altogether? Then they are only build together with the actual benchmarks.
added 1 commit
- eda48c62 - Reposition benchmark tools test in hierarchy per MR discussion
enabled an automatic merge when the pipeline for eda48c62 succeeds
mentioned in commit d513b0cf
changed milestone to %0.18.00
changed milestone to %0.17.00
Please register or sign in to reply