Remove propagator options from vertexing configs and performance upgrades
All threads resolved!
All threads resolved!
This MR
- removes the propagator options from all tool configs and creates them instead just before invoking the propagator: In general, the context objects needed for creating the tool configs are not available at the time of tool instantiation and could potentially vary event by event. Therefore all methods relying on the propagator now take
GeometryContext
andMagneticFieldContext
objects as input and create the propagator options on the fly. - merges
VertexFitterOptions
andVertexFinderOptions
toVertexingOptions
as they were identical and no differentiation between them is needed. It also avoid some useless copying whereVertexFinderOptions
were converted intoVertexFitterOptions
. - Completely orthogonal to the two items above (but happened to land in the same MR, sorry): Updates the implementation of the AnnealingTool to make it computationally more efficient.
Edited by Bastian Schlag
Merge request reports
Activity
changed milestone to %0.20.00
added Critical label
added 1 commit
- e8a2b3de - update FullBilloirVertexFitter to correctly initialize all variables
assigned to @pagessin
- Resolved by Bastian Schlag
added 1 commit
- 4b62273a - Apply suggestion to Core/include/Acts/Vertexing/LinearizerConcept.hpp
@pagessin okay cool, thanks! All threads are resolved.
enabled an automatic merge when the pipeline for 4b62273a succeeds
mentioned in commit b89df02d
mentioned in merge request atlas/atlasexternals!660 (merged)
Please register or sign in to reply