Skip to content
Snippets Groups Projects

Remove propagator options from vertexing configs and performance upgrades

Merged Bastian Schlag requested to merge performance_updates_amvf into master
All threads resolved!

This MR

  • removes the propagator options from all tool configs and creates them instead just before invoking the propagator: In general, the context objects needed for creating the tool configs are not available at the time of tool instantiation and could potentially vary event by event. Therefore all methods relying on the propagator now take GeometryContext and MagneticFieldContext objects as input and create the propagator options on the fly.
  • merges VertexFitterOptions and VertexFinderOptions to VertexingOptions as they were identical and no differentiation between them is needed. It also avoid some useless copying where VertexFinderOptions were converted into VertexFitterOptions.
  • Completely orthogonal to the two items above (but happened to land in the same MR, sorry): Updates the implementation of the AnnealingTool to make it computationally more efficient.
Edited by Bastian Schlag

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ok seems fine I think.

  • Paul Gessinger approved this merge request

    approved this merge request

  • Bastian Schlag resolved all threads

    resolved all threads

  • Bastian Schlag added 1 commit

    added 1 commit

    • 4b62273a - Apply suggestion to Core/include/Acts/Vertexing/LinearizerConcept.hpp

    Compare with previous version

  • Author Maintainer

    @pagessin okay cool, thanks! All threads are resolved.

  • Paul Gessinger approved this merge request

    approved this merge request

  • Paul Gessinger enabled an automatic merge when the pipeline for 4b62273a succeeds

    enabled an automatic merge when the pipeline for 4b62273a succeeds

  • Paul Gessinger mentioned in commit b89df02d

    mentioned in commit b89df02d

  • Please register or sign in to reply
    Loading