Skip to content
Snippets Groups Projects

Remove propagator options from vertexing configs and performance upgrades

Merged Bastian Schlag requested to merge performance_updates_amvf into master

This MR

  • removes the propagator options from all tool configs and creates them instead just before invoking the propagator: In general, the context objects needed for creating the tool configs are not available at the time of tool instantiation and could potentially vary event by event. Therefore all methods relying on the propagator now take GeometryContext and MagneticFieldContext objects as input and create the propagator options on the fly.
  • merges VertexFitterOptions and VertexFinderOptions to VertexingOptions as they were identical and no differentiation between them is needed. It also avoid some useless copying where VertexFinderOptions were converted into VertexFitterOptions.
  • Completely orthogonal to the two items above (but happened to land in the same MR, sorry): Updates the implementation of the AnnealingTool to make it computationally more efficient.
Edited by Bastian Schlag

Merge request reports

Pipeline #1512050 passed

Pipeline passed for 4b62273a on performance_updates_amvf

Test coverage 65.00% (-1.00%) from 1 job

Merged by Paul GessingerPaul Gessinger 4 years ago (Mar 25, 2020 6:10pm UTC)

Loading

Pipeline #1512130 passed

Pipeline passed for b89df02d on master

Test coverage 65.00% (-1.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading