Make ParameterSet store covariance as optional instead of pointer

This should have the advantage of it being local to the class, rather than a heap allocation that the client has to perform and pass to ParameterSet.

changed milestone to %0.10.04

added Improvement label

changed title from Make ParameterSet store covariance as optional instead of pointr to Make ParameterSet store covariance as optional instead of pointer

added 1 commit

• 6d0e0a8a - format?

Compare with previous version

changed milestone to %0.12.00

The MR is great, and I would approve it - what's the issue with the KalmanFitterUnitTest ?

added Approved label

I marked as Approved, once we figure the UnitTest failure out, I will fully approve it.

I'll look into that. Hadn't tested on LCG95.

added 1 commit

• 2f1dce6d - fix problem with dangling reference (i think)

Compare with previous version

added 9 commits

• 2f1dce6d...208abc3a - 4 commits from branch master
• f1fc71be - Switch ParameterSet and TrackParemeters to optional
• 41be50ca - accout for weird move behavior of optional
• beffa5bc - Rename m_pCovariance to m_optCovariance
• fe63976b - format?
• e3ad0046 - fix problem with dangling reference (i think)

Compare with previous version

added 7 commits

• e3ad0046...d3ece91c - 2 commits from branch master
• 225d8737 - Switch ParameterSet and TrackParemeters to optional
• 84fe7acb - accout for weird move behavior of optional
• d13c9122 - Rename m_pCovariance to m_optCovariance
• 47efb67d - format?
• b06c3bbb - fix problem with dangling reference (i think)

Compare with previous version

added 7 commits

• b06c3bbb...370c2230 - 2 commits from branch master
• 9859b245 - Switch ParameterSet and TrackParemeters to optional
• 35478475 - accout for weird move behavior of optional
• 015836a8 - Rename m_pCovariance to m_optCovariance
• 02b637cb - format?
• d84067a3 - fix problem with dangling reference (i think)

Compare with previous version

changed milestone to %0.10.04

@asalzbur Can we merge this? You approved it already before, I think.

added 8 commits

• d84067a3...3f6e89fb - 3 commits from branch master
• e4da1e49 - Switch ParameterSet and TrackParemeters to optional
• 662dad32 - accout for weird move behavior of optional
• 405d4ace - Rename m_pCovariance to m_optCovariance
• f5247b68 - format?
• 71a5d648 - fix problem with dangling reference (i think)

Compare with previous version

resolved all discussions

i like it. since this is a somewhat performance critical piece of code, I think it would be interesting to know any effects on performance of this change.

approved this merge request

mentioned in commit 4569549d

merged

mentioned in merge request atlas/atlasexternals!547 (merged)

mentioned in merge request atlas/athena!26660 (merged)