Skip to content
Snippets Groups Projects

Relace barcode service

Merged Moritz Kiehn requested to merge remove_barcode_service into master
All threads resolved!

Replace the configurable barcode coding service BarcodeSvc and separate barcode_type with a fixed Barcode object. The configuration was not used anywhere and the encoding is in any case specialized to our specific use case.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bastian Schlag added 1 commit

    added 1 commit

    • 7adff7dc - Apply suggestion to Algorithms/Generators/ACTFW/Generators/EventGenerator.cpp

    Compare with previous version

  • Bastian Schlag resolved all threads

    resolved all threads

  • Bastian Schlag added 1 commit

    added 1 commit

    • e1577bfe - Apply suggestion to Plugins/Pythia8/ACTFW/Generators/Pythia8ProcessGenerator.cpp

    Compare with previous version

  • Bastian Schlag approved this merge request

    approved this merge request

  • Moritz Kiehn added 14 commits

    added 14 commits

    • e1577bfe...6ae538c2 - 2 commits from branch master
    • 28a9b3fd - EventData: replace BarcodeSvc w/ directly encoded Barcode
    • 927915b8 - Core: use Barcode
    • 9e98efce - Algorithms: replace BarcodeSvc w/ Barcode
    • 487d9f6f - Io: replace BarcodeSvc w/ Barcode
    • 6943a5ce - HepMC3: use Barcode
    • 2e977222 - Pythia8: only assign primary ids via Barcode
    • 35c71077 - Examples: remove BarcodeSvc
    • d8b95da8 - move hit printer to separate module
    • bf07d970 - Printers: add particle printer
    • 31883981 - Examples: generator examples print particles
    • e9652c30 - Apply suggestion to Algorithms/Generators/ACTFW/Generators/EventGenerator.cpp
    • 2c2a1de0 - Apply suggestion to Plugins/Pythia8/ACTFW/Generators/Pythia8ProcessGenerator.cpp

    Compare with previous version

  • Moritz Kiehn enabled an automatic merge when the pipeline for 2c2a1de0 succeeds

    enabled an automatic merge when the pipeline for 2c2a1de0 succeeds

  • Moritz Kiehn mentioned in commit a6dda5a8

    mentioned in commit a6dda5a8

  • merged

  • Please register or sign in to reply
    Loading