Follow-up from "DetectorField: Perform Field Lookup on Per-Pixel Basis"
The following discussion from !560 (merged) should be addressed:
-
@pschutze started a discussion: (+2 comments) I have a few points that aim more towards an improper use of the feature and/or safety checks:
- When I use
SENSOR
I can still provide a fraction of a pixel as a field and use afield_scale
less than 1, but that doesn't really make sense, right? Meaning, for theSENSOR
mapping we could constrain thefield_scale
to values >=1 and/or check that the size of the provided map already is a multiple of a pixel. - Right now, when providing a
field_mapping != SENSOR
I still have the possibility to alter the field via thefield_scale
. This doesn't make much sense in my eyes and leads to odd results. The only point where it could become interesting is when a map of more than one pixel is loaded, but then theSENSOR
could/should be used, no?- For the fields where we do read the physical size of the grid from the file, we could even implement a check whether the calculated field size is exactly matching the pixel size.
Plus one very general comment:
-
@simonspa You renamed the
field_mapping
values toPIXEL_*
, but forgot to change the READMEs.
- When I use