Skip to content

Improvements to the ElectricFieldReader

Simon Spannagel requested to merge fix_efieldreader into master

This MR adds a few improvements to the ElectricFieldReader module:

  • The field cache is now actually used - was just sitting there before. Fields are only parsed once now.
  • Check for detector dimensions has been removed from static file parser and moved upwards in hierarchy. Only downside: field is read and parsed before the check happens. Doesn't matter.
  • Check for detector dimensions now takes thickness domain, i.e. depletion_depth is honored.
  • FieldData had to be amended with the actual field sizes. Change is only local to to the module, detector gets the same information as before. Had to use a std::tuple - not very beautiful but it's working.
  • Logging is improved, progress reported when parsing file. Makes sense for large files as has been found (see #135 (closed))

Let me know if you'd like me to change anything - else merge.

This fixes #135 (closed).

Merge request reports