Skip to content

Rework Behavior of PulseTransfer Module

Simon Spannagel requested to merge warning_pulsetransfer into master

Currently, the PulseTransfer modules fails silently with input data that contains charge but no pulse information. This is e.g. the case when using GenericPropagation (which just records the last position) in conjunction with PulseTransfer.

This MR adds a WARNING-level printout that no pulses have been found in input data. The text is:

Propagated charge object does not contain any pulses. Ensure that you are using a matching propagation module.

Not sure if this is optimal. I have also thought about artificially creating a pseudo-pulse just using the charge of the input object but that quickly leads to some complications:

  • We need to decide on a binning for the pulses, and there is no way to get this right without hard-coding something or adding a config parameter
  • Do we assign the charge to bin 0 or do we try to reconstruct when the charges have arrived at the implant?

The question basically is: do we want the PulseTransfer module to work properly also with GenericPropagation/ProjectionPropagation to basically reconstruct an "arrival-time" pulse of charges or not?

Edited by Simon Spannagel

Merge request reports