Resolve "code cleanup of the plotter"
This is not the fully cleaned-up version yet, but all the (expected) changes to the output files are in now, such that it seems more useful to make a new branch to work on the code cleanup that should not change the outputs.
Release Notes
Only very few changes to the usage have emerged from te cleanup:
- The former tag
style.legendHeightis now calledgeometry.legend.heightto increase consistency. - If several signal samples are added to a plot with a sub-plot, the drawing order in the sub-plot is now consistent with the drawing order in the main canvas (which it was not before).
For all the differences, check summary.pdf
Edited by Carsten Burgard
Merge request reports
Activity
added 1 commit
- c1eb359a - undo some of the code moving to allow merging
added 893 commits
-
c1eb359a...c0f5a7ec - 892 commits from branch
master - e34d31cd - merged master into feature branch
-
c1eb359a...c0f5a7ec - 892 commits from branch
added 41 commits
-
e34d31cd...c3c5e636 - 40 commits from branch
master - 3092424b - Merge branch 'master' into '21-code-cleanup-of-the-plotter'
-
e34d31cd...c3c5e636 - 40 commits from branch
added 226 commits
-
3092424b...ec813358 - 171 commits from branch
master - 561826c6 - added initial version of plotting tests
- 0b7712af - Wrote a function to remove the timestamp in .C files.
- 43809c01 - Made regexp a little looser.
- c38c7526 - Added some tag handling and looping. Still work in progress.
- 54e34a52 - plotting.py is getting more and more messed up...but it works so far
- d94d5adf - Try script. Especially try changes in addDefaultTags.
- 4814b71b - Generating large list of tags with constraints quite well. Plotting and filenames work fine.
- 68781fda - Added automatically generated files to .gitignore.
- 1017ccca - Support for finding commit hashes.
- d9ef7203 - Basics of plot comparisons work. Pipeline is expected to fail. See if it fails…
- ccb80f72 - Debug gitlab website interface
- 7f7c851f - Further debugging. Look in cmake_test if it can connect to gitlab website.
- d326fa79 - Try again.
- e5dc25e2 - Try accessing $CI_JOB_TOKEN from .gitlab-ci.yml.
- 0b409193 - Another attempt...
- 132fae6e - Try CAF token for authentication.
- 7fe15648 - CAF token authentication seems to work. Test from within python script now.
- 70ab0bd7 - Upload artifacts in cmake_test. Exit plotting.py early so that the pipeline runs successfully.
- 5afc37ed - Try again.
- 71cdb8ef - Why does CI fail?
- d629c968 - Are files in directory "build/testing"?
- e07ea3fc - Dump entire folder structure.
- 70c2e165 - Use correct path for artifacts
- 114ab634 - Use correct path for artifacts.
- 0f8560cb - Test comparing script.
- 76454514 - Can specify commit to test against.
- 901183a3 - Added correct commit hash.
- 5696befb - Adding artifacts for all test chains (except debug chain). Remove debugging info…
- c03d477c - Minor changes. Print job name for debugging purposes.
- 2c1aea4e - Now really added debugging info.
- dd9a8506 - Renamed artifacts. Find out where files are written in cmake standalone test.
- 879ac88f - In anticipation for the next merge, support comparisons between same chains. Pipeline will fail.
- 59e5ae8f - Correct path for cmake standalone test. All debugging output removed.
- 6210fb95 - Merge branch '94-no-tests-for-tq-hww-plotter' into testing-for-94
- 91f135ec - Added new reference commit manually.
- fe2c77c5 - Edit comments.
- eddcdf10 - Merge branch 'testing-for-94' into 94-no-tests-for-tq-hww-plotter
- b4deb1ed - Many small changes and debugging.
- bb1063ff - Add list of hashes to artifacts.
- 087eabc4 - CI fix.
- 82a0cf66 - Simplification in finding common ancestor commit.
- 4417ea2d - Added realistic set of default tags and some alternative values. Still not complete.
- 81338ee5 - python3 compatibility, CLI and 'labels.0' fix
- 31889885 - Work in progress: adding tags to test case.
- edc7d2bc - Added some more tags.
- 096314ab - Added more tags.
- f7c7d6a3 - Added two error messages that help to find logical errors. Currently, 99 plots…
- 51a51558 - Ready to merge into TQPlotter feature branch and test.
- 6d8fea4e - Change reference commit.
- 62be69b1 - First attempt at fuzzy-matching in plotting tests.
- a4b4a673 - First version of fuzzy matching. Todo: change output to something more readable.
- 2aac191a - Fuzzy-matching improved. File with output from "diff"s is written and uploaded to artifacts.
- 596a1409 - CI fix.
- 663db9f9 - Merge branch 'master' into 94-no-tests-for-tq-hww-plotter
- b3440206 - Merge branch '94-no-tests-for-tq-hww-plotter' into 21-code-cleanup-of-the-plotter
Toggle commit list-
3092424b...ec813358 - 171 commits from branch
added 1 commit
- 8668ffb6 - Updated reference commit for plotting test. Small bugfix.
added 14 commits
- 3f130d81 - Cosmetic changes.
- bfef4e39 - Upload artifacts of plotting test even if the job fails.
- 090776ec - Try CI fix.
- 05066575 - Debugging CI.
- 5ad06a9c - Reverted the last two commits to fix CI. See if this works.
- f05bdbd8 - Further debugging.
- bdc137f4 - Try to trick CI.
- 767cf4fa - CI fix.
- e1b91b55 - Fix.
- 19881a0a - Make CI output like before.
- 068b3b00 - Fix.
- 4a1a7865 - Again.
- 8e88295a - Updated reference commit in plotting test case. Pipeline should succeed now. If…
- ef08471f - Merge branch '94-no-tests-for-tq-hww-plotter' into 21-code-cleanup-of-the-plotter
Toggle commit listadded 13 commits
- 25f7ab88 - Small bugfix.
- 767ee2a8 - added some magic to hopefully improve the ordering and naming of objects in .C files
- 25ca2db7 - Merge branch '94-no-tests-for-tq-hww-plotter' of…
- 56586024 - Small fix in python script. But list of primitives cannot be sorted.
- 79d3e2c9 - added function to sort lists by object names
- 3a3a7336 - python3 fixes
- 32ad494b - added sorting to ensure consistent layout of .C files
- 57b4ac3d - Many cosmetic changes and clean-up.
- e7102812 - Rewrote testing in scripts. It should be more consistent now for cmake-standalone and rc chain.
- 804fdd4e - 94 kon
- 51b5f5ed - Merge branch '94_kon' into '94-no-tests-for-tq-hww-plotter'
- e869b0f4 - Changed reference commit for plotting.py.
- ff2e33bf - Merge branch '94-no-tests-for-tq-hww-plotter' into 21-code-cleanup-of-the-plotter
Toggle commit listadded 40 commits
-
ff2e33bf...059e6ffa - 39 commits from branch
master - 99b84f80 - Merge branch 'master' into '21-code-cleanup-of-the-plotter'
-
ff2e33bf...059e6ffa - 39 commits from branch
added 3 commits
-
99b84f80...115dcc09 - 2 commits from branch
master - d807bdbd - Merge branch 'master' into '21-code-cleanup-of-the-plotter'
-
99b84f80...115dcc09 - 2 commits from branch
added 3 commits
added 7 commits
- 4bd5ef0c - Propagation of theory uncertainties to histograms
- 2fcf37af - Create and clean up some tags
- 402b4827 - Merge branch '21-code-cleanup-of-the-plotter' into 'theo-uncert-histograms'
- 39d5e180 - cleanup
- abcd9242 - more cleanup
- ccbeac0f - fixed reference
- 962dfe3a - Merge branch 'theo-uncert-histograms' into '21-code-cleanup-of-the-plotter'
Toggle commit listadded 1 commit
- 392311c3 - separated ROOT functionality from TQPlotter into TQROOTPlotter
Please register or sign in to reply