Skip to content
Commit d8883b6b authored by Carsten Burgard's avatar Carsten Burgard 💬
Browse files

Merge branch 'reading-more-input-files' into 'master'

adding move flexibility for input files

See merge request !532
parents 3ba9288c 63e1f61c
Loading
Loading
Loading
Pipeline #1154878 passed with stages
in 21 minutes and 23 seconds
Loading
  • Contributor

    Hey @cburgard,

    This commit causes an issue for @ngrieser in the HWW high-mass analysis during sample initialization (using V20 PAODs).

    In this commit, the added line in initialize.py sets the tag xAODCutBookKeeperContainer to STREAM_AOD. Before this was done, the default was defined here and was StreamAOD. Did you change this on purpose? Is this maybe a difference between PAODs and mAODs? Please have a look and fix it.

    Konstantin

  • Author Owner

    Hi @kolehman, no, this was not intentional. I intended to provide the option to change this in CommonAnalysisHelpers, not to change the default behavior. Does it work when changing this to

    initializer.setTagString("xAODCutBookKeeperContainer", campConfig.getTagStringDefault("~initializer.xAODCutBookKeeperContainer","StreamAOD"))
  • Developer

    Hi Carsten I made this change and I still cannot initialize:

    ERROR in TQSampleInitializerBase::getTreeInformation(...) : no valid sumOfWeights could be retrieved from cutBookkeepers for file '/raid07/users/grieser/PAODs/V20SystPFLOW/mc16d/user.bwinter.skimmed-sys_CAFxAOD_EMPFlow_v20_mc-c16d/CAFxAOD_skim_PFlow_v20_c16d_bkg_X_X_top_singletop_Wt_PoPy_dilep_DR_top_410648_s.part0_group.phys-higgs.410648.e6615_e5984_s3126_r10201_r10210_p3875.18535680.PAOD_2LDF._000097.root'. If the file is expected to be a valid xAOD file it might have been corrupted.
    Edited by Nate Grieser
  • Author Owner

    This is confusing... can you add the expected stream name to the error message?

  • Benedict Tobias Winter @bwinter

    mentioned in issue #296 (closed)

    ·

    mentioned in issue #296 (closed)

    Toggle commit list
  • Benedict Tobias Winter @bwinter

    mentioned in commit 99a7a79e

    ·

    mentioned in commit 99a7a79e

    Toggle commit list
  • Konstantin Lehmann @kolehman

    mentioned in merge request !546 (merged)

    ·

    mentioned in merge request !546 (merged)

    Toggle commit list
  • Maintainer

    The fix Carsten suggested for the xAODCutBookKeeperContainer issue works for the JER branch. See CI results for commits 897ebca1 and ad2fb73d here https://gitlab.cern.ch/atlas-physics/higgs/hww/HWWAnalysisCode/commits/80-update-fit-config-to-use-v20-jer-uncertainties. I'll merge it into the master

  • Contributor
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment