Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Umami Umami
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • atlas-flavor-tagging-toolsatlas-flavor-tagging-tools
  • algorithmsalgorithms
  • UmamiUmami
  • Merge requests
  • !685

Fixing common variable bug in PDF sampling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacob Edwin Crosby requested to merge jcrosby-missing-var-resampling into master Dec 12, 2022
  • Overview 12
  • Commits 6
  • Pipelines 9
  • Changes 4

Summary

This MR introduces the following changes

  • Adding retrieve_common_variables function. Checks the per sample available variables and will return all common variables which are available in all samples. Also prints warnings when variables are not in all samples available.
  • Fixing an issue in the PDF sampling where the common variables were not used to merge the resampled flavour files into the final resampled file. This caused crashes when running over samples with different variables available.

Conformity

  • Changelog entry
  • Documentation
  • Development guidelines
  • Style guides
Edited Feb 01, 2023 by Alexander Froch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jcrosby-missing-var-resampling