Skip to content

R22 - Make shared hit cut configurable

Samuel Van Stroud requested to merge svanstro/training-dataset-dumper:svanstro/fix-shared-hit-cut into r22

I've added a config entry for the two remaining hardcoded cuts in the TrackSelector.cxx. At the moment the shared hit cut is unchanged, though I suggest removing this cut altogether. It's also worth questioning whether we still want the other hit based cuts here - for example upstream tracking changes now require all tracks to have at least 8 Si hits, so the si_hits_minimum is currently redundant. The pix_holes_maximum is set to 1, but this choice may not be well optimised.

Regarding the confusion around the SCT shared hit - I'm pretty sure that the AuxVar being accessed (numberOfSCTSharedHits), is already the number of shared hits, not the number of shared modules, so the division by 2 is not required.

Slides from today: https://indico.cern.ch/event/1071129/#2-gnn-update

Edited by Samuel Van Stroud

Merge request reports