Skip to content
Snippets Groups Projects

add a new config file to save gn2 flip outputs and mSV

Merged Nicole Michelle Hartman requested to merge hartman/training-dataset-dumper:main into main
All threads resolved!

Merging for Neal's QP

@svanstro @alfroch

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Froch
  • Alexander Froch
  • Alexander Froch
  • I guess these should fix everything once it is rebased to main

  • added 1 commit

    • d460874f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • fe811823 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • bc02256a - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Alexander Froch
  • added 1 commit

    • c96e7c44 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 5 commits

    • c96e7c44...c0c2ac6d - 4 commits from branch atlas-flavor-tagging-tools:main
    • 4dac61ba - Merge branch training-dataset-dumper:main into main

    Compare with previous version

  • Hello! Thank you for the feedback @afroch and @npond

    I didn't know before we could start from the GN3_dev.json config, so doing that now as Nikita suggested :heart_eyes:

    I think I had f***ed smth up earlier this afternoon blindly accepting the gitlab suggestions, but in the meantime, Alex had saved an intermediate GN2Flip.json file, so I started from that tonight :smile:

    What I learned:

    • Our MultifoldTagger CA decorates the btagging object instead of the jet object (so needed to switch out that)
    • Now since starting from the GN3_dev.json config, I made a new config file: fragments/pflow-sv1-jf.json that just adds the extra sv1, jf variables.

    OK, it's now clear the extra code I added on top of GN3_dev.json it much more minimal :) (altho, it does look a bit like config file spaghetti :spaghetti: )

  • Good news: The extra variables I wanted are all there now :smile:

    image

    And... I also have the SV1 mass so @neal can compare to for investigating swapping the mSV1 var to fit the flavor fractions w/ the reco GN2 mass .

    image

    ^ Demonstration test dump has these new vars

  • added 3 commits

    • 5e74794b - add alexs edits
    • e3a29afd - Merge branch 'main' of ssh://gitlab.cern.ch:7999/hartman/training-dataset-dumper
    • 76a8efd3 - push working edits

    Compare with previous version

  • Nicole Michelle Hartman resolved all threads

    resolved all threads

  • Nicole Michelle Hartman enabled an automatic merge when all merge checks for 76a8efd3 pass

    enabled an automatic merge when all merge checks for 76a8efd3 pass

  • Alexander Froch approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading