Skip to content
Snippets Groups Projects

Adding new FTAG1 p6698 Samples

1 unresolved thread

Description

  • Adding new FTAG1 samples to the grid samples list. Samples where produced here
  • Adding new GN3 & GNTau versions to the output
  • Removing GN2v01 versions without aux tasks and with leptons
  • Changing JetMatcher label from HadronConeExclTruthLabelID to HadronGhostTruthLabelID

Review checklist:

  • CI Passing
  • Comments addressed
  • Source branch is up to date with target
Edited by Alexander Froch

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Samuel Van Stroud
  • Alexander Froch added 1 commit

    added 1 commit

    Compare with previous version

  • Alexander Froch resolved all threads

    resolved all threads

  • Alexander Froch added 1 commit

    added 1 commit

    • 869d6db9 - Changing JetMatcher label from HadronConeExclTruthLabelID to HadronGhostTruthLabelID

    Compare with previous version

  • Alexander Froch resolved all threads

    resolved all threads

  • Alexander Froch changed the description

    changed the description

  • Alexander Froch added 1 commit

    added 1 commit

    • b1d85e11 - Removing old variables from the configs

    Compare with previous version

  • Alexander Froch added 1 commit

    added 1 commit

    Compare with previous version

  • Alexander Froch marked the checklist item CI Passing as completed

    marked the checklist item CI Passing as completed

  • Alexander Froch marked the checklist item Comments addressed as completed

    marked the checklist item Comments addressed as completed

  • Alexander Froch marked the checklist item Source branch is up to date with target as completed

    marked the checklist item Source branch is up to date with target as completed

  • Alexander Froch marked this merge request as ready

    marked this merge request as ready

    • I'm going to defer to @svanstro for review here unless this is really urgent (he knows this better than I do).

    • It looks good to me. We are adding a lot of variables for the GN3 ablations which I don't really think we will need... but ok, better to have them now and then drop them later

    • Yeah depends on how people are doing the development here. I'd always hoped that people would use e.g. GN3 as a baseline configuration and make their own datasets as needed. This would favor having a small baseline configuration and then maybe a beefier one for some central studies.

      But it seems like most (or maybe all) of the production is pretty centralized. Is your impression that pretty much everyone works with the centrally produced files?

    • Author Maintainer

      From my personal feeling, yes

    • Please register or sign in to reply
  • Alexander Froch added 1 commit

    added 1 commit

    • 75e16515 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Samuel Van Stroud approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading