Skip to content

GitLab

Closed
Created by Spyros Argyropoulos@sargyropMaintainer

Harmonisation of printouts in tranform and generator interfaces

Most of the printouts from the transform have the following format:

IDENTIFIER KEYWORD = VALUE

e.g.

08:29:01 Py:Gen_tf            INFO .transform =                  Gen_tf

however this very often not the case. A few examples:

08:29:01 Py:Gen_tf            INFO  nEventsPerJob set to 2000
08:29:01 Py:Gen_tf            INFO Requested output events 100
08:29:01 Py:Gen_tf         WARNING Could not find evgenkeywords.txt file EvgenJobTransforms/evgenkeywords.txt in $JOBOPTSEARCHPATH
05:14:02      Nb of events :  20000

This means that new checks that would otherwise be trivial to implement require changes in several places (e.g. !863 (merged)) and the introduction of logic which is "hacky".

We should make sure that new printouts always conform to the correct format IDENTIFIER KEYWORD = VALUE both in the transform but also in the generator interfaces and the above line should be printed only once in log.generate

I am not sure what is the best approach here. Perhaps put this in place as a "coding rule" and make everyone aware of this. (Strict checks would probably be more time-consuming to implement than just putting in place coding practices)

@ewelina I just opened this so that we somehow bring it up with the generator experts to make things easier in the future. You probably know best how to address this and maybe can discuss this in a GIT meeting.

Edited by Spyros Argyropoulos