Skip to content
Snippets Groups Projects

Implement check for missing evgenkeywords

Merged Spyros Argyropoulos requested to merge lp into master
All threads resolved!

Changes introduced

Make logParser throw a warning if the transform prints:

Py:Gen_tf         WARNING Could not find evgenkeywords.txt file

Tests

With log from #128 (closed)
Screenshot_2021-01-04_at_14.20.56
and if the above line is not present in the log it will print
Screenshot_2021-01-02_at_11.28.09

Issues resolved

Closes #128 (closed)

Edited by Christian Gutschow

Merge request reports

Pipeline #2232335 passed

Pipeline passed for c54e04d5 on lp

Approved by

Merged by Christian GutschowChristian Gutschow 4 years ago (Jan 14, 2021 5:12pm UTC)

Merge details

  • Changes merged into master with f0f363de (commits were squashed).
  • Deleted the source branch.

Pipeline #2232340 passed

Pipeline passed for f0f363de on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #132 (closed)

  • added 1 commit

    Compare with previous version

  • Spyros Argyropoulos changed the description

    changed the description

  • Hi @cgutscho and @sargyrop sorry for the problem. It was fixed before Christmas and should be available in the next release. atlas/athena!39401 (merged)

    Cheers, ewelinA

  • Thanks @ewelina! So in case the transform can't find it, why don't we let the CI print a warning that prints to screen an https link to the evgenkeywords.txt file and ask that the user / JO coordinator checks that key words used in the JO actually exist in that file? What do you think, @sargyrop?

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Spyros Argyropoulos changed the description

    changed the description

  • added 1 commit

    • 1b8b8181 - actually pushing the previous change

    Compare with previous version

  • just to add that we want to build a new release this week. At the moment we wait for a MG patch to be applied by Genser. When it is done we will provide a new release.

  • Christian Gutschow resolved all threads

    resolved all threads

  • added 20 commits

    Compare with previous version

  • Christian Gutschow approved this merge request

    approved this merge request

  • Christian Gutschow unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Please register or sign in to reply
    Loading