Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • MC Job Options MC Job Options
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • atlas-physics
  • pmg
  • MC Job OptionsMC Job Options
  • Merge requests
  • !1161

LO EFT samples for 4top

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Shayma Wahdan requested to merge dsid_swahdan_507438 into master May 17, 2021
  • Overview 14
  • Commits 5
  • Pipelines 8
  • Changes 2

JIRA ticket

ATLMCPROD-9311

Checklist for requesters

  • I have followed the guidelines in McSampleRequestProcedure
  • I have provided the ATLMCPROD JIRA ticket where the request has been discussed
  • The request has been approved by the PA/CP group

Checklist for approvers

  • All the items in the "Checklist for requesters" have been completed successfully
  • The pipeline has run and the status is green (if it is orange look at the CI job output and iterate with the requesters to sort out the issues if possible)
  • CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
  • Look at the output of the child pipeline created by run_child_pipeline and make sure that at least one run_athena_DSID job has run. If it's not the case, confirmation from the PMG conveners is necessary before merging
  • Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
  • Check that no file has been modified or deleted
  • Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
  • Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block
Edited May 22, 2021 by Christian Gutschow
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dsid_swahdan_507438