Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • MC Job Options MC Job Options
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • atlas-physics
  • pmg
  • MC Job OptionsMC Job Options
  • Merge requests
  • !1786

Merged
Created Apr 21, 2022 by Spyros Argyropoulos@sargyropMaintainer

Make check_logParser fail if logParser run fails in any way (e.g. exception thrown)

  • Overview 7
  • Commits 11
  • Pipelines 3
  • Changes 1

Description of bug

Currently if the logParser fails the check_logParser CI job doesn't fail. This is because python scripts/logParser.py ... | tee ... always returns 0 because of the tee.

Changes introduced

Use correct variable to check return status of logParser.py

Tests

Before fix

Screenshot_2022-04-20_at_21.08.27

After fix

Screenshot_2022-04-21_at_13.22.39

See pipelines in this MR: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/21240292

Issues resolved

Closes #

Edited Apr 21, 2022 by Spyros Argyropoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fixParser