Skip to content

Fix recursive adding of files in DSID subdirectories in commit script

Spyros Argyropoulos requested to merge fixcommit into master

Description of bug

In !1588 (merged) the line

for file in $(find $dsiddir/* -not -type d); do

was replaced with

for newfile in glob.glob(f'{dsiddir}/*', recursive = True):

which is not equivalent. The latter fails to expand subdirectories and as a result if we have files in a structure like DSID/Herwig7_i/SomeModule.py, SubModule.py is not added to the commit.

Changes introduced

Fix globbing pattern

Tests

Before

Screenshot_2024-02-18_at_07.11.32

After

Screenshot_2024-02-18_at_07.11.20

Issues resolved

Closes #

Merge request reports