Skip to content

Implementing CI checks discussed in ATLMCPROD-7100

Spyros Argyropoulos requested to merge (removed):master into master

This MR includes the implementation of the first CI with the following checks:

  • checking JO naming based on a modified version of skel.GENtoEVGEN.py from https://svnweb.cern.ch/trac/atlasoff/browser/Generators/EvgenJobTransforms/trunk/share/skeleton.GENtoEVGEN.py These are implemented in the script scripts/check_jo_consistency.py
  • checking that the physics short is unique in the repository scripts/check_unique_physicsShort.sh
  • checking that a MR that requests to register new jO (triggered by the [jo ci] commit message) does not modify/delete any existing file in the repository. Implemented in scripts/check_modified_files.sh
  • checking that a single log.generate file is present in directory containing new jO and that it passes the logParser checks. Implemented in scripts/check_logParser.sh. If successful the job triggers a new commit saying that the pipeline was successful and removes the log.generate file
  • README.md file
  • merge request templates to be used when making a MR with new jO

The last successful pipeline is here: https://gitlab.cern.ch/sargyrop/mcjoboptions/pipelines/841189 (now without the share directory).

Let me also tag @ewelina since there I put BlackList_caches.txt and evgenkeywords.txt in the common directory otherwise logParser would fail.

I also added logParser as a git submodule (actually a modified version thereof which is pointing to a new branch)

Closes #5 (closed)

Edited by Spyros Argyropoulos

Merge request reports

Loading