Skip to content
Snippets Groups Projects

Single-top PhPy8A14rb non-filtered jOs

Merged Lucia Keszeghova requested to merge dsid_keszeghova5_603719 into master

Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.

JIRA ticket

ATLMCPROD-11201

Checklist for approval

This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.

  • I have followed the guidelines in McSampleRequestProcedure
  • I have provided the ATLMCPROD JIRA ticket where the request has been discussed
  • The request has been approved by the PA/CP group
  • The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
  • If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
  • CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
  • Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
  • Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
  • Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block
  • Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.
Edited by Lucia Keszeghova

Merge request reports

Merge request pipeline #7374968 passed

Merge request pipeline passed for 295a9605

Merged by Lucia KeszeghovaLucia Keszeghova 7 months ago (May 13, 2024 10:43am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lucia Keszeghova marked the checklist item I have followed the guidelines in McSampleRequestProcedure as completed

    marked the checklist item I have followed the guidelines in McSampleRequestProcedure as completed

  • Lucia Keszeghova marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

    marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

  • Lucia Keszeghova marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

    marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

  • Lucia Keszeghova marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

    marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

  • Lucia Keszeghova marked the checklist item I have provided the ATLMCPROD JIRA ticket where the request has been discussed as completed

    marked the checklist item I have provided the ATLMCPROD JIRA ticket where the request has been discussed as completed

  • added 1 commit

    • 6b102777 - Correcting scope in log.generate.shorts

    Compare with previous version

  • added 1 commit

    • 376ec683 - Correcting scope in log.generate.shorts 2

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Lucia Keszeghova marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

    marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

  • Lucia Keszeghova marked the checklist item If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers as completed

    marked the checklist item If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers as completed

  • Lucia Keszeghova marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

    marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

  • Lucia Keszeghova marked the checklist item The request has been approved by the PA/CP group as completed

    marked the checklist item The request has been approved by the PA/CP group as completed

  • Lucia Keszeghova marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

    marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

  • Lucia Keszeghova approved this merge request

    approved this merge request

Please register or sign in to reply
Loading