Skip to content

Fix in run_athena

Spyros Argyropoulos requested to merge athenafix into master

Description of bug

From @avroy

While trying to add some JOs today, I had the git CIs fail twice because the JO had the following lines:

evgenConfig.nEventsPerJob = 5000
nevents = 1.1*evgenConfig.nEventsPerJob

The first time it failed, it took the second line to evaluate nEventsPerJob and the parsing command in run_athena.sh definitely made no sense, since it expects a line of the first type. As a result, $nEvents is empty and eventually Gen_tf.py fails.

Changes introduced

  • grep for ^\s*evgenConfig.nEventsPerJob\s*=' in order to exclude lines starting with anything else than evgenConfig.nEventsPerJob potentially pre-pended with white-spaces and followed by white-spaces and =

Tests

I tested on a file containing

#evgenConfig.nEventsPerJob = 1000
evgenConfig.nEventsPerJob   = 2000
#evgenConfig.nEventsPerJob = 3000
nevents = 1.1*evgenConfig.nEventsPerJob

and it correctly prints out 2000 as expected

@avroy can you git pull and say if this fixes your first problem?

Issues resolved

Closes #

Merge request reports