Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • MC Job Options MC Job Options
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • atlas-physics
  • pmg
  • MC Job OptionsMC Job Options
  • Merge requests
  • !560

Add CI check for number of grid files in gridpack

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Spyros Argyropoulos requested to merge checkgrid into master Jul 07, 2020
  • Overview 1
  • Commits 11
  • Pipelines 2
  • Changes 4

Changes introduced

  • New check implemented in check_grid (not skippable) which counts how many files a gridpack contains and throws an error if nfiles > 80k
  • Renaming of grid-related CI jobs (for clarity)

Tests

Gridpack with more than 80k files

Screenshot_2020-07-07_at_12.26.11

Gridpack with less than 80k files

Screenshot_2020-07-07_at_12.31.15

Issues resolved

Closes #117 (closed)

I have to use [skip all] since the renamed files under scripts are not in the whitelist (we don't want people to put new scripts there).

Edited Jul 07, 2020 by Spyros Argyropoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: checkgrid