Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • MC Job Options MC Job Options
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • atlas-physics
  • pmg
  • MC Job OptionsMC Job Options
  • Merge requests
  • !631

Bug fix for reading lhe input files for tW DS1, DS2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olga Bessidskaia Bylund requested to merge dsid_obessids_500794 into master Aug 18, 2020
  • Overview 10
  • Commits 6
  • Pipelines 3
  • Changes 2

Description of bug

Ticket: ATLMCPROD-8469 DSIDs: 500794, 500795 There was a crash in official production at the very end of the madspin_on_lhe() function, which performs MadSpin decays on input lhe files from MadGraph. This crash occurs if you pass a tarred file to to madspin_on_lhe() (e.g. TXT.440006._000388.tar.gz) but for an untarred file (e.g. TXT.440005._000822.events). Error message: 12:13:06 Py:MadGraphUtils INFO Unzipping generated events. 12:13:07 gzip: TXT.440006._000485.tar.gz.gz: No such file or directory

Changes introduced

Ugly workaround, untarring the inputGeneratorFile and passing that to madspin_on_lhe(). It is what I got to work. I see a pipeline failing because runArgs.inputGeneratorFile is specified in the JOs. Would the jobs crash in official production (they ran locally) or is this just bad practice?

Tests

Tested in current mode and in a mode where the output file from MadSpin was removed (to make sure it is actually used, which it is).

Issues resolved

In my local test, yes. Closes #

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: dsid_obessids_500794