Skip to content
Snippets Groups Projects

Update the plugin interface to accommodate the publishing of FPV and AXF nodes

All threads resolved!

This MR is the companion of MR GeoModelDev/GeoModel!8 (merged) , and must be built, in fact, on top of the latter.

This MR updates the plugins to follow the changes introduced in GeoModel to let users (subsystems, in particular) publish list of FullPhysVol and AlignableTransform nodes.

In particular:

  • The GeoVGeometryPlugin class now features an additional constructor, which takes a std::string as an argument, to set the plugin's name. The parameterized constructor also creates a unique_ptr to an instance of GeoModelKernel/GeoPublisher.
  • The GeoVGeometryPlugin plugin owns the unique_ptr as a private class member and it returns raw pointers to that by mean of the getPublisher() method. Classes that derive from GeoVGeometryPlugin will use the getPublisher method to get the raw pointer.
  • Simple plugins that do not have to publish nodes can use the default GeoVGeometryPlugin() constructor. The plugins that wish to publish nodes can use the parameterized constructor, then implement the publishing code in the create() method.
  • The plugin's method create(GeoVPhysVol*, bool) now accepts an optional boolean argument to trigger/enable the publishing of GeoModel nodes by the plugin. Applications using the plugin can trigger the publishing by passing a true to the create(...) method; then they can get the publisher pointer by calling the plugin's getPublisher() method.
Edited by Riccardo Maria Bianchi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • cab4c4bf - Moved to the newest version of plugin and publishing mechanism

    Compare with previous version

  • added 4 commits

    • 2de47400 - renaming from Store to Publisher to reflect the latest changes in GeoModelKernel
    • f13c25a5 - remove unused implementation file
    • bde81bba - Moved to latest changes in GeoPublisher/GeoVGeometryPlugin
    • d951f6ee - Rename folder of Toy example with custom publisher

    Compare with previous version

  • added 7 commits

    Compare with previous version

  • added 1 commit

    • 10790f67 - Move AccordionPlugin example to the new GeoVGeometryPlugin and GeoPublisher

    Compare with previous version

  • added 1 commit

    • 9551a199 - Move HGTDPlugin example to the new GeoVGeometryPlugin and GeoPublisher

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • OK, the MR is now compatible with the latest changes in GeoModel. It can be merged as soon as GeoModelDev/GeoModel!8 (merged) will be merged.

    Edited by Riccardo Maria Bianchi
  • Riccardo Maria Bianchi resolved all threads

    resolved all threads

  • added 1 commit

    • 935c4e10 - Removed GeoVStore from plugins, following the change in GeoModelKernel (GeoVStore was removed).

    Compare with previous version

  • added 1 commit

    • 619acc0c - Move to new publishing syntax to reflect latest changes in GeoPublisher

    Compare with previous version

  • added 1 commit

    • 7d700820 - Updated plugins' interface to reflect the use of unique_ptr by the GeoVGeometryPlugin base class.

    Compare with previous version

  • added 1 commit

    • 7b31a71b - removed redundant 'data' folder

    Compare with previous version

  • Riccardo Maria Bianchi resolved all threads

    resolved all threads

  • added 1 commit

    • 934b8edf - Adapted plugins to latest changes in GeoModelKernel's GeoVGeometryPlugin and GeoPublisher

    Compare with previous version

  • Riccardo Maria Bianchi changed the description

    changed the description

  • Riccardo Maria Bianchi resolved all threads

    resolved all threads

  • Vakhtang Tsulaia
  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • Vakhtang Tsulaia
  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • mentioned in commit 62c303bf

  • Riccardo Maria Bianchi resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading