Skip to content
Snippets Groups Projects
  • Edward Moyse's avatar
    1f17019e
    More improvements to try to get new configuration working. · 1f17019e
    Edward Moyse authored and Walter Lampl's avatar Walter Lampl committed
    This was mostly done by enabling wrapping (it's off by default) and using my comparison script:
    https://gitlab.cern.ch/emoyse/Scripts/-/blob/master/CompareConfigs.py
    
    Changes to match old config
    - MuonTrackSummaryHelperToolCfg should use AtlasExtrap
    - InDetTrackSummaryHelperToolCfg should have InDet set to true
    - MooCandidateMatchingToolCfg should use MuonStraightLineExtrap
    - MuonCombinedInDetDetailedTrackSelectorToolCfg uses new AtlasTrackSummaryToolCfg
    - SolenoidalIntersectorCfg has same name as old config, to allow for deduplication
    - misc changes to match naming of oldconfiguration
    - Correct naming of MuonCombinedInDetCandidateAlgCfg and added missing LRT configuration (currently off by default)
    - Add missing MuonAlignmentErrorDbAlg to MuonGeometryConfig and added missed folder for MuonAlign errors
    
    Improvements to configuration:
    - Added AtlasTrackSummaryToolCfg
    - Wrapping Debug commented out (will be removed once debugging finished)
    - switch MuonCreatorTool to use summarytool which knows about ID
    - added some more new flags to wrapping (will eventually need to handle this all properly)
    - MuonCombinedRecoConfig: Need to enable ID via Detector.Reco flags now
    - Temporarily comment out MuonAlignmentErrorDbAlg (causes lots of errors in some workflows)
    1f17019e
    History
    More improvements to try to get new configuration working.
    Edward Moyse authored and Walter Lampl's avatar Walter Lampl committed
    This was mostly done by enabling wrapping (it's off by default) and using my comparison script:
    https://gitlab.cern.ch/emoyse/Scripts/-/blob/master/CompareConfigs.py
    
    Changes to match old config
    - MuonTrackSummaryHelperToolCfg should use AtlasExtrap
    - InDetTrackSummaryHelperToolCfg should have InDet set to true
    - MooCandidateMatchingToolCfg should use MuonStraightLineExtrap
    - MuonCombinedInDetDetailedTrackSelectorToolCfg uses new AtlasTrackSummaryToolCfg
    - SolenoidalIntersectorCfg has same name as old config, to allow for deduplication
    - misc changes to match naming of oldconfiguration
    - Correct naming of MuonCombinedInDetCandidateAlgCfg and added missing LRT configuration (currently off by default)
    - Add missing MuonAlignmentErrorDbAlg to MuonGeometryConfig and added missed folder for MuonAlign errors
    
    Improvements to configuration:
    - Added AtlasTrackSummaryToolCfg
    - Wrapping Debug commented out (will be removed once debugging finished)
    - switch MuonCreatorTool to use summarytool which knows about ID
    - added some more new flags to wrapping (will eventually need to handle this all properly)
    - MuonCombinedRecoConfig: Need to enable ID via Detector.Reco flags now
    - Temporarily comment out MuonAlignmentErrorDbAlg (causes lots of errors in some workflows)
Code owners
Assign users and groups as approvers for specific file changes. Learn more.