Merge branch 'clang10.EventInfo-20200708' into 'master'

EventInfo+xAODTau+TrigConfIO+MuonEventTPCnv: Fix clang 10 warnings.

See merge request atlas/athena!34563

Event/EventInfo/src/EventStreamInfo.cxx

 /*
-   Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+   Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
  */
 
 /** @file EventStreamInfo.cxx
@@ -99,7 +99,7 @@ EventStreamInfo::print(MsgStream& log) const {
   }
   log << MSG::DEBUG << endmsg;
   log << MSG::DEBUG << "EventStreamInfo Processing Tags: ";
-  for (const std::string tag : m_processingTags) {
+  for (const std::string& tag : m_processingTags) {
     log << MSG::DEBUG << tag << ", ";
   }
   log << MSG::DEBUG << endmsg;

Event/xAOD/xAODTau/Root/TauJet_v3.cxx

@@ -537,7 +537,7 @@ namespace xAOD {
   /// Get the v<const pointer> to a given tauTrack collection associated with this tau
   std::vector<const TauTrack*> TauJet_v3::tracksWithMask(unsigned int mask )const {
   std::vector<const TauTrack*> trks;
-    for(const ElementLink< xAOD::TauTrackContainer > link : tauTrackAcc(*this) ){
+    for(const ElementLink< xAOD::TauTrackContainer >& link : tauTrackAcc(*this) ){
       const TauTrack* trk = *link;
       if(trk->flagWithMask(mask)){
 	trks.push_back(trk);

MuonSpectrometer/MuonCnv/MuonEventTPCnv/src/MuonRDO/MM_RawDataContainerCnv_p1.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "MuonEventTPCnv/MuonRDO/MM_RawDataContainerCnv_p1.h"
@@ -40,7 +40,7 @@ void  Muon::MM_RawDataContainerCnv_p1::persToTrans(const Muon::MM_RawDataContain
   if (DEBUG) log<<MSG::VERBOSE<<"MM_RawDataContainerCnv_p1::persToTrans with MM_RawDataContainer_p1 with this many collections "<<numColl<<std::endl;
     
   MM_RawDataCollection* coll = nullptr;
-  for ( const MM_RawDataCollection_p1 collection : *persCont){
+  for ( const MM_RawDataCollection_p1& collection : *persCont){
 
     coll = new MM_RawDataCollection(collection.m_idHash);
     if ( transCont->addCollection(coll,collection.m_idHash).isFailure() ) {

MuonSpectrometer/MuonCnv/MuonEventTPCnv/src/MuonRDO/STGC_RawDataContainerCnv_p1.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "MuonEventTPCnv/MuonRDO/STGC_RawDataContainerCnv_p1.h"
@@ -39,7 +39,7 @@ void  Muon::STGC_RawDataContainerCnv_p1::persToTrans(const Muon::STGC_RawDataCon
   if (DEBUG) log<<MSG::VERBOSE<<"STGC_RawDataContainerCnv_p1::persToTrans with STGC_RawDataContainer_p1 with this many collections "<<numColl<<std::endl;
     
   STGC_RawDataCollection* coll = nullptr;
-  for ( const STGC_RawDataCollection_p1 collection : *persCont){
+  for ( const STGC_RawDataCollection_p1& collection : *persCont){
     coll = new STGC_RawDataCollection(collection.m_idHash);
     if ( transCont->addCollection(coll,collection.m_idHash).isFailure() ) {
       log << MSG::WARNING << "Could not add the sTGC collection during persistent->transient conversion" << std::endl;

Trigger/TrigConfiguration/TrigConfIO/utils/TriggerMenuRW.cxx

 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include <cstdlib>
@@ -245,9 +245,9 @@ int main(int argc, char** argv) {
             fileLoader.loadFile( fn, jo);
             cout << "Loaded job options with " << jo.getObject("properties").getKeys().size() << " entries " << endl;
             if( cfg.detail ) {
-               for( const auto alg : jo.getObject("properties").data()) {
+               for( const auto& alg : jo.getObject("properties").data()) {
                   std::cout << alg.first << std::endl;
-                  for( const auto prop : alg.second ) {
+                  for( const auto& prop : alg.second ) {
                      std::cout << "      " << prop.first << " -> " << prop.second.data() << std::endl;
                   }
                }
@@ -292,9 +292,9 @@ int main(int argc, char** argv) {
       if (jo) {
          cout << "Loaded job options with " << jo.getObject("properties").getKeys().size() << " entries " << endl;
          if( cfg.detail ) {
-            for( const auto alg : jo.getObject("properties").data()) {
+            for( const auto& alg : jo.getObject("properties").data()) {
                std::cout << alg.first << std::endl;
-               for( const auto prop : alg.second ) {
+               for( const auto& prop : alg.second ) {
                   std::cout << "      " << prop.first << " -> " << prop.second.data() << std::endl;
                }
             }