McParticleAlgs: enable flake8 and fix code

PhysicsAnalysis/TruthParticleID/McParticleAlgs/CMakeLists.txt

@@ -14,6 +14,6 @@ atlas_add_component( McParticleAlgs
                      LINK_LIBRARIES ${CLHEP_LIBRARIES} GaudiKernel AthenaBaseComps NavFourMom McParticleEvent McParticleKernel McParticleUtils )
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_joboptions( share/*.py )
 

PhysicsAnalysis/TruthParticleID/McParticleAlgs/python/JobOptCfg.py

@@ -7,9 +7,8 @@ __doc__    = "hold a set of customized configurables and factory functions"
 __author__ = "Sebastien Binet <binet@cern.ch>"
 __version__= "$Revision: 1.14 $"
 
-import EventKernel.ParticleDataType
 from .McParticleAlgsConf import TruthParticleBuilder
-
+from AthenaCommon import CfgMgr
 
 class PileUpClassification(object):
     # same order as in McParticleEvent/PileUpClassification.h # PLEASE keep in sync with this header !!
@@ -52,7 +51,6 @@ class McAodBuilder( TruthParticleBuilder ):
             return
 
         from .McAodFlags import jobproperties as jp
-        from AthenaCommon.AppMgr import ToolSvc
         from AthenaCommon.Configurable import Configurable
         
         if not hasattr(hdl, 'FilterTool'):
@@ -108,7 +106,6 @@ def createMcAodBuilder( name = "McAodBuilder",
     Factory function to create a fully and correctly configured customized
     TruthParticleBuilder algorithm
     """
-    from AthenaCommon import CfgMgr
     if doTruthEtIsolations is None:
         from .McAodFlags import jobproperties as jp
         doTruthEtIsolations = jp.McAodFlags.doTruthEtIsolations()
@@ -224,7 +221,7 @@ class TruthParticleContainerGetter(Configured):
             )
         self._seq += builder
         mlog =  logging.getLogger( self.__class__.__name__)        
-        mlog.info(" Recorded the %s ESD TruthParticle shadow collection - will be recreated on the fly "%(self.outputKey(),))
+        mlog.info("Recorded the %s ESD TruthParticle shadow collection - will be recreated on the fly", self.outputKey())
         objKeyStore.addStreamESD("TruthParticleContainer",self.outputKey())
         
         return True

PhysicsAnalysis/TruthParticleID/McParticleAlgs/python/ReOrderMcEventCollection.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # @file:    McParticleAlgs/python/FixMcEventCollection.py
 # @purpose: <put some purpose here>
@@ -11,7 +11,6 @@ IMPORTANT : this alg must be run before any other algs invoking TruthParticleCnv
 __version__ = '$Revision: 1.5 $'
 __author__  = 'P-A Delsart'
 
-import AthenaCommon.SystemOfUnits as Units
 import AthenaPython.PyAthena as PyAthena
 from AthenaPython.PyAthena import StatusCode
 

PhysicsAnalysis/TruthParticleID/McParticleAlgs/python/tests.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 
 from McParticleTools.McParticleToolsConf import EtaPtFilterTool
-from McParticleTools.McParticleToolsConf import OldSpclMcFilterTool
-from McParticleTools.McParticleToolsConf import NoopFilterTool
 from McParticleTools.McParticleToolsConf import TruthParticleCnvTool
-from McParticleTools.McParticleToolsConf import TruthIsolationTool
 
 from McParticleAlgs.McParticleAlgsConf import TruthParticleBuilder
 class test_McAodBuilder( TruthParticleBuilder ):
@@ -43,7 +40,6 @@ class test_McAodBuilder( TruthParticleBuilder ):
     pass # test_McAodBuilder
 
 from McParticleTools.McParticleToolsConf import GenAodValidationTool
-from McParticleTools.McParticleToolsConf import SpclMcValidationTool
 from McParticleTools.McParticleToolsConf import HepMcWriterTool
 from McParticleAlgs.McParticleAlgsConf   import McAodValidationAlg
 
@@ -75,7 +71,6 @@ class test_McAodValidation( McAodValidationAlg ):
     pass # test_McAodValidation
 
 from McParticleTools.McParticleToolsConf import McVtxFilterTool
-from McParticleTools.McParticleToolsConf import TruthParticleCnvTool
 from McParticleAlgs.McParticleAlgsConf   import McAodFilter
 
 class test_McAodFilter( McAodFilter ):