Skip to content
Snippets Groups Projects
Commit 5d6af8b8 authored by Dimitra Amperiadou's avatar Dimitra Amperiadou
Browse files

Fix transform order & remove remmaant from ActsMuonChamberTool

parent d9f3468b
1 merge request!69412Muon Chamber bounds typo correction and fix in the Configuration of ActsMuonDetectorCfg
This commit is part of merge request !69412. Comments created here will be created in the context of that merge request.
......@@ -4,8 +4,6 @@ from AthenaConfiguration.ComponentFactory import CompFactory
def MuonDetectorBuilderToolCfg(flags, name="MuonDetectorBuilderTool", **kwargs):
result = ComponentAccumulator()
from MuonStationGeoHelpers.MuonStationGeoHelpersCfg import ActsMuonChamberToolCfg
kwargs.setdefault("ChamberBuilder", result.getPrimaryAndMerge(ActsMuonChamberToolCfg(flags)))
theTool = CompFactory.ActsTrk.MuonDetectorBuilderTool(name, **kwargs)
result.addPublicTool(theTool, primary = True)
return result
\ No newline at end of file
......@@ -101,7 +101,7 @@ StatusCode ChamberAssembleTool::buildReadOutElements(MuonDetectorManager &mgr) {
for (const MuonReadoutElement* re : candidate.readoutEles) {
const GeoShape* readOutShape = re->getMaterialGeom()->getLogVol()->getShape();
std::vector<Amg::Vector3D> reEdges = m_geoUtilTool->shapeEdges(readOutShape,
re->localToGlobalTrans(gctx) * toCenter);
toCenter * re->localToGlobalTrans(gctx));
edgePoints.insert(edgePoints.end(), std::make_move_iterator(reEdges.begin()),
std::make_move_iterator(reEdges.end()));
reIds.push_back(re->identify());
......@@ -112,11 +112,11 @@ StatusCode ChamberAssembleTool::buildReadOutElements(MuonDetectorManager &mgr) {
for (const Amg::Vector3D& edge : edgePoints) {
if (edge.z() > 0.) {
minX1 = std::min(minX1, edge.x());
maxX1 = std::max(maxX1, edge.x());
maxX1 = std::max(maxX1, edge.x());
} else {
minX2 = std::min(minX2, edge.x());
maxX2 = std::max(maxX2, edge.x());
maxX2 = std::max(maxX2, edge.x());
}
minY = std::min(minY, edge.y());
maxY = std::max(maxY, edge.y());
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment