Skip to content
Snippets Groups Projects
Commit 63b978b9 authored by Nicolas Köhler's avatar Nicolas Köhler
Browse files

suppress further MDT calib warnings

parent 76a798aa
6 merge requests!58791DataQualityConfigurations: Modify L1Calo config for web display,!46784MuonCondInterface: Enable thread-safety checking.,!46776Updated LArMonitoring config file for WD to match new files produced using MT,!45405updated ART test cron job,!42417Draft: DIRE and VINCIA Base Fragments for Pythia 8.3,!38912Suppress further MDT calib warnings
...@@ -126,6 +126,7 @@ private: ...@@ -126,6 +126,7 @@ private:
SG::ReadCondHandleKey<AtlasFieldCacheCondObj> m_fieldCacheCondObjInputKey {this, "AtlasFieldCacheCondObj", "fieldCondObj", "Name of the Magnetic Field conditions object key"}; SG::ReadCondHandleKey<AtlasFieldCacheCondObj> m_fieldCacheCondObjInputKey {this, "AtlasFieldCacheCondObj", "fieldCondObj", "Name of the Magnetic Field conditions object key"};
ServiceHandle<Muon::IMuonIdHelperSvc> m_idHelperSvc {this, "MuonIdHelperSvc", "Muon::MuonIdHelperSvc/MuonIdHelperSvc"}; ServiceHandle<Muon::IMuonIdHelperSvc> m_idHelperSvc {this, "MuonIdHelperSvc", "Muon::MuonIdHelperSvc/MuonIdHelperSvc"};
bool m_hasBISsMDT;
}; };
#endif #endif
...@@ -92,8 +92,8 @@ MdtCalibrationTool::Imp::Imp(std::string name) : ...@@ -92,8 +92,8 @@ MdtCalibrationTool::Imp::Imp(std::string name) :
{} {}
MdtCalibrationTool::MdtCalibrationTool(const std::string& type, const std::string &name, const IInterface* parent) MdtCalibrationTool::MdtCalibrationTool(const std::string& type, const std::string &name, const IInterface* parent) : base_class(type, name, parent),
: base_class(type, name, parent) m_hasBISsMDT(false)
{ {
m_imp.reset(new MdtCalibrationTool::Imp(name)); m_imp.reset(new MdtCalibrationTool::Imp(name));
// settable properties // settable properties
...@@ -134,6 +134,11 @@ StatusCode MdtCalibrationTool::initialize() { ...@@ -134,6 +134,11 @@ StatusCode MdtCalibrationTool::initialize() {
ATH_MSG_INFO("Processing configuration for layouts with BMG chambers."); ATH_MSG_INFO("Processing configuration for layouts with BMG chambers.");
m_imp->m_BMGid = m_idHelperSvc->mdtIdHelper().stationNameIndex("BMG"); m_imp->m_BMGid = m_idHelperSvc->mdtIdHelper().stationNameIndex("BMG");
} }
int bisIndex=m_idHelperSvc->mdtIdHelper().stationNameIndex("BIS");
Identifier bis7Id = m_idHelperSvc->mdtIdHelper().elementID(bisIndex, 7, 1);
if (m_idHelperSvc->issMdt(bis7Id)) m_hasBISsMDT=true;
// initialise MuonGeoModel access // initialise MuonGeoModel access
ATH_CHECK(detStore()->retrieve( m_imp->m_muonGeoManager )); ATH_CHECK(detStore()->retrieve( m_imp->m_muonGeoManager ));
...@@ -258,9 +263,15 @@ bool MdtCalibrationTool::driftRadiusFromTime( MdtCalibHit &hit, ...@@ -258,9 +263,15 @@ bool MdtCalibrationTool::driftRadiusFromTime( MdtCalibHit &hit,
// get t0 shift from tool (default: no shift, value is zero) // get t0 shift from tool (default: no shift, value is zero)
if (m_imp->m_doT0Shift) t0 += m_imp->m_t0ShiftSvc->getValue(id); if (m_imp->m_doT0Shift) t0 += m_imp->m_t0ShiftSvc->getValue(id);
} else { } else {
ATH_MSG_WARNING("MdtTubeCalibContainer not found for " if (m_hasBISsMDT) {
<< m_idHelperSvc->mdtIdHelper().print_to_string( id )); static std::atomic<bool> bisWarningPrinted = false;
ATH_MSG_WARNING( "Tube cannot be calibrated!!!" ); if (!bisWarningPrinted) {
ATH_MSG_WARNING("MdtTubeCalibContainer not found for " << m_idHelperSvc->mdtIdHelper().print_to_string( id ) << " - Tube cannot be calibrated, cf. ATLASRECTS-5819");
bisWarningPrinted.store(true, std::memory_order_relaxed);
}
} else {
ATH_MSG_WARNING("MdtTubeCalibContainer not found for " << m_idHelperSvc->mdtIdHelper().print_to_string( id ) << " - Tube cannot be calibrated!");
}
return false; return false;
} }
...@@ -480,7 +491,7 @@ bool MdtCalibrationTool::twinPositionFromTwinHits( MdtCalibHit &hit, ...@@ -480,7 +491,7 @@ bool MdtCalibrationTool::twinPositionFromTwinHits( MdtCalibHit &hit,
} else { } else {
ATH_MSG_WARNING( "MdtTubeCalibContainer not found for " ATH_MSG_WARNING( "MdtTubeCalibContainer not found for "
<< m_idHelperSvc->mdtIdHelper().print_to_string( id ) ); << m_idHelperSvc->mdtIdHelper().print_to_string( id ) );
ATH_MSG_WARNING( "Tube cannot be calibrated!!!" ); ATH_MSG_WARNING( "Tube cannot be calibrated!!" );
return false; return false;
} }
......
...@@ -464,7 +464,11 @@ StatusCode MdtCalibDbAlg::loadRt(const MuonGM::MuonDetectorManager* muDetMgr){ ...@@ -464,7 +464,11 @@ StatusCode MdtCalibDbAlg::loadRt(const MuonGM::MuonDetectorManager* muDetMgr){
double innerTubeRadius = -9999.; double innerTubeRadius = -9999.;
const MuonGM::MdtReadoutElement *detEl = muDetMgr->getMdtReadoutElement( m_idHelperSvc->mdtIdHelper().channelID(athenaId,1,1,1) ); const MuonGM::MdtReadoutElement *detEl = muDetMgr->getMdtReadoutElement( m_idHelperSvc->mdtIdHelper().channelID(athenaId,1,1,1) );
if( !detEl ){ if( !detEl ){
ATH_MSG_INFO( "Ignoring nonexistant station in calibration DB: " << m_idHelperSvc->mdtIdHelper().print_to_string(athenaId) ); static std::atomic<bool> rtWarningPrinted = false;
if (!rtWarningPrinted) {
ATH_MSG_WARNING("loadRt() - Ignoring nonexistant station in calibration DB: "<<m_idHelperSvc->mdtIdHelper().print_to_string(athenaId)<<", cf. ATLASRECTS-5826");
rtWarningPrinted.store(true, std::memory_order_relaxed);
}
} else { } else {
innerTubeRadius = detEl->innerTubeRadius(); innerTubeRadius = detEl->innerTubeRadius();
} }
...@@ -830,7 +834,11 @@ StatusCode MdtCalibDbAlg::loadTube(const MuonGM::MuonDetectorManager* muDetMgr){ ...@@ -830,7 +834,11 @@ StatusCode MdtCalibDbAlg::loadTube(const MuonGM::MuonDetectorManager* muDetMgr){
bool isValid = true; // the elementID takes a bool pointer to check the validity of the Identifier bool isValid = true; // the elementID takes a bool pointer to check the validity of the Identifier
Identifier chId = m_idHelperSvc->mdtIdHelper().elementID(name,ieta,iphi,true,&isValid); Identifier chId = m_idHelperSvc->mdtIdHelper().elementID(name,ieta,iphi,true,&isValid);
if (!isValid) { if (!isValid) {
ATH_MSG_WARNING("Element Identifier " << chId.get_compact() << " retrieved for station name " << name << " is not valid, skipping..."); static std::atomic<bool> idWarningPrinted = false;
if (!idWarningPrinted) {
ATH_MSG_WARNING("Element Identifier " << chId.get_compact() << " retrieved for station name " << name << " is not valid, skipping, cf. ATLASRECTS-5826");
idWarningPrinted.store(true, std::memory_order_relaxed);
}
continue; continue;
} }
...@@ -981,7 +989,11 @@ MuonCalib::MdtTubeCalibContainer* MdtCalibDbAlg::buildMdtTubeCalibContainer(cons ...@@ -981,7 +989,11 @@ MuonCalib::MdtTubeCalibContainer* MdtCalibDbAlg::buildMdtTubeCalibContainer(cons
ATH_MSG_VERBOSE( " new det el " << detEl ); ATH_MSG_VERBOSE( " new det el " << detEl );
if( !detEl ){ if( !detEl ){
ATH_MSG_INFO( "Ignoring nonexistant station in calibration DB: " << m_idHelperSvc->mdtIdHelper().print_to_string(id) ); static std::atomic<bool> warningPrinted = false;
if (!warningPrinted) {
ATH_MSG_WARNING("buildMdtTubeCalibContainer() - Ignoring nonexistant station in calibration DB: "<<m_idHelperSvc->mdtIdHelper().print_to_string(id)<<", cf. ATLASRECTS-5826");
warningPrinted.store(true, std::memory_order_relaxed);
}
} else { } else {
int nml = 2; int nml = 2;
if( !detEl2 ) nml = 1; if( !detEl2 ) nml = 1;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment