Merge branch 'cppcheck.CaloRec-20210319' into 'master'

CaloRec: Fix cppcheck warnings.

See merge request !41763

Calorimeter/CaloRec/share/CaloRec_dump.C

@@ -70,7 +70,7 @@ t3333->Draw("(TimeTotal-TimeSum)/1000");
 
 MyC5->Print("CBNTdump.ps)");
  
-if (hfile) hfile->Close();
+hfile->Close();
 
 }
 

Calorimeter/CaloRec/share/CaloRec_histComp.C

@@ -324,8 +324,7 @@ fclose(fich);
  
   hfile->Write();
 
-  if (hfile) 
-    hfile->Close();
+  hfile->Close();
 }
 
 void CaloRec_makeHist()

Calorimeter/CaloRec/src/CaloTopoTmpHashClusterBase.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 //-----------------------------------------------------------------------
@@ -57,11 +57,13 @@ public:
 
     reference operator*()
     {
+      // cppcheck-suppress returnTempReference; false positive
       return reinterpret_cast<reference> (pointer_list::iterator::operator*());
     }
 
     reference operator->()
     {
+      // cppcheck-suppress returnTempReference; false positive
       return reinterpret_cast<reference> (pointer_list::iterator::operator*());
     }
   };