Skip to content
Snippets Groups Projects
Commit d0295a0a authored by Fenfen An's avatar Fenfen An
Browse files

use smart pointer to resolve memory leak

parent 2188e794
No related branches found
No related tags found
1 merge request!20779WIP: Migrate DataQualityTools to ToolHandles
...@@ -71,8 +71,7 @@ StatusCode PixMapOverlayWriter::initialize(){ ...@@ -71,8 +71,7 @@ StatusCode PixMapOverlayWriter::initialize(){
StatusCode PixMapOverlayWriter::execute(){ StatusCode PixMapOverlayWriter::execute(){
DetectorSpecialPixelMap* spm = new DetectorSpecialPixelMap(); auto spm = std::make_unique<DetectorSpecialPixelMap>();
for(unsigned int i = 0; i < m_pixelID->wafer_hash_max(); i++){ for(unsigned int i = 0; i < m_pixelID->wafer_hash_max(); i++){
spm->push_back(new ModuleSpecialPixelMap()); spm->push_back(new ModuleSpecialPixelMap());
} }
...@@ -348,15 +347,13 @@ StatusCode PixMapOverlayWriter::execute(){ ...@@ -348,15 +347,13 @@ StatusCode PixMapOverlayWriter::execute(){
} }
sc = m_specialPixelMapSvc->registerCondAttrListCollection(spm); sc = m_specialPixelMapSvc->registerCondAttrListCollection(spm.get());
if( !sc.isSuccess() ){ if( !sc.isSuccess() ){
ATH_MSG_FATAL( "Unable to register CondAttrListCollection" ); ATH_MSG_FATAL( "Unable to register CondAttrListCollection" );
return StatusCode::FAILURE; return StatusCode::FAILURE;
} }
delete spm;
return StatusCode::SUCCESS; return StatusCode::SUCCESS;
} }
......
...@@ -586,7 +586,7 @@ void PixelChargeInterpolationValidation::WriteErrorsFile(std::string name){ ...@@ -586,7 +586,7 @@ void PixelChargeInterpolationValidation::WriteErrorsFile(std::string name){
} }
parameters->Print(name.c_str()); parameters->Print(name.c_str());
delete parameters;
delete[] values; delete[] values;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment