Cleanup link dependencies, enable flake8 and fix code.

Soshi Tsuno authored 4 years ago and Adam Edward Barton committed 4 years ago

revert removal of some condalgs which are needed in the legacy trigger (prevents problems with ordering of the condSeq)

Former-commit-id: 04d0b012

Susumu Oda authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: 1ae805d495493b8d489a4a2729d488f575e1cb16

Former-commit-id: f56eac95

This merge request pulls in update to the FastSiDigitization package
from the ~"21.3" branch, so that the code matches, other than in the
case of known migrations that have taken place in ~master (e.g. the
migration to Conditions Algorithms in the SCT.)

Changes related to the `HepMcParticleLink` migration have been left
out as they are not yet ready to go into ~master.


Former-commit-id: f739c72f

Former-commit-id: d013975e

Former-commit-id: a7d14be2

Susumu Oda authored 7 years ago and Adam Edward Barton committed 7 years ago

Former-commit-id: 84e8a868

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

This reverts commit 9156e32a [formerly f73d17d3], reversing
changes made to 27d106d1 [formerly 8f2f5188].


Former-commit-id: 9d67f5b8

Tamara Vazquez Schroeder authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Using a different Ambiguities map for PU in PixelFastDigitizationTool

See merge request !6442

Former-commit-id: 9e0f48ba

James Beacham authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Fix FastSiDigitizationConfig.py for Fast Chain in 21.0. ATLASSIM-3405

See merge request !5799

Former-commit-id: 2febb0bd

Removed temperature

Merged methods into execute.

Cleaned up

Remove HV write handle.

Use intersetion of ranges of state and HV.

Add SCT_DCSConditionsCondAlg configuration.

Add messages for debugging.

Debugging. This is OK.

Going back to the original header file

Changed variable names

Revert constructor

Revert options of InDetRecConditionsAccess.py

Revert the initialize to the original one except HV readhandle initialize

Revert to old initialize

Revert the original version except for the DEBUG message for valid write cond handle

Add delete. Use m_doState variable

Rename SCT_DCSConditionsCondAlg to SCT_DCSConditionsStatCondAlg

Add SCT_DCSConditionsTempCondAlg

Implemented SCT_DCSConditionsTempCondAlg

Fixed bugs

Fixed bugs

Implemented SCT_DCSConditionsHVCondAlg

Implemented SCT_DCSConditionsHVCondAlg

Compiled

Modify SCT_DCSConditionSvc to use the outputs of conditions algorithms.

Implemented conditions algorithms in several places. (HITtoRDO of q221 is not working)

Revert the folder specification.

Fix bugs

Protection against duplication

Fix bugs

Remove MOCH_TM1_RECV part

Revert "Remove MOCH_TM1_RECV part"

This reverts commit e759867c [formerly a3bc864c].

Revert "Revert "Remove MOCH_TM1_RECV part""

This reverts commit 835b2b48 [formerly e6df98b9].

Add protection against null objects

Remove m_writeKey.dbKey() to cope with the modification of ICondSvc

Add REGISTER_CC


Former-commit-id: 36be4a57

Former-commit-id: 58f06caf

Former-commit-id: 2320465a

python/FastSiDigitizationConfig.py (FastClusterMakerTool): tweak logic in FastClusterMakerTool CfgGetter method.  cmt/requirements - add use statements for CxxUtils and StoreGate. FastSiDigitization/SCT_FastDigitizationTool.h, src/SCT_FastDigitizationTool.cxx - switch to using SG::WriteHandles separate out the creation of output containers and checking for neighbouring clusters into separate methods. Use CHECK macro wherever possible. Make variables const wherever possible. Rename some local variables to make code easier to read. Improve logic in cluster merging code. Whitespace-cleanup. ATLASSIM-2407 Tagged as FastSiDigitization-00-01-10 (FastSiDigitization-00-01-10)

	* python/FastSiDigitizationConfig.py (FastClusterMakerTool): tweak
	logic in FastClusterMakerTool CfgGetter method. ATLASSIM-2407

	* cmt/requirements - add use statements for CxxUtils and
	StoreGate. ATLASSIM-2407

	* FastSiDigitization/SCT_FastDigitizationTool.h,
	src/SCT_FastDigitizationTool.cxx - switch to using
	SG::WriteHandles separate out the creation of output containers
	and checking for neighbouring clusters into separate methods. Use
	CHECK macro wherever possible. Make variables const wherever
	possible. Rename some local variables to make code easier to
	read. Improve logic in cluster merging
	code. Whitespace-cleanup. ATLASSIM-2407
	* Tagged as FastSiDigitization-00-01-10

2015-11-25  Vladimir Lyubushkin
	* src/SCT_FastDigitizationTool.cxx - Fix for assigning to
	nonexistent elements of AmgSymMatrix. ATLASSIM-2407
...
(Long ChangeLog diff - truncated)

src/PixelFastDigitizationTool.cxx, src/SCT_FastDigitizationTool.cxx, FastSiDigitization/SCT_FastDigitizationTool.h, FastSiDigitization/PixelFastDigitizationTool.h - veto writing geantinos into PRD Truth. Fix for truth seeded reco running. python/FastSiDigitizationConfig.py, python/FastSiDigitizationConfigDb.py - fix random number stream configuration, so that we can freely mix full and fast digi when digitizing the hard-scatter and pile-up Hits separately. Requires Digitization-01-16-00 or later. Set HardScatterSplittingMode to zero for PixelFastDigitizationToolSplitNoMergePU and SCT_FastDigitizationToolSplitNoMergePU. ATLASSIM-2174. Tagged as FastSiDigitization-00-01-03 (FastSiDigitization-00-01-03)

	* src/PixelFastDigitizationTool.cxx,
	src/SCT_FastDigitizationTool.cxx,
	FastSiDigitization/SCT_FastDigitizationTool.h,
	FastSiDigitization/PixelFastDigitizationTool.h - veto writing
	geantinos into PRD Truth. Fix for truth seeded reco running.
	* python/FastSiDigitizationConfig.py,
	python/FastSiDigitizationConfigDb.py - fix random number stream
	configuration, so that we can freely mix full and fast digi when
	digitizing the hard-scatter and pile-up Hits separately. Requires
	Digitization-01-16-00 or later. Set HardScatterSplittingMode to
	zero for PixelFastDigitizationToolSplitNoMergePU and
	SCT_FastDigitizationToolSplitNoMergePU. ATLASSIM-2174.
	* Tagged as FastSiDigitization-00-01-03

2015-08-13  John Chapman  <John.Chapman@cern.ch>

	* python/FastSiDigitizationConfig.py,
	python/FastSiDigitizationConfigDb.py - add
	PixelFastDigitizationToolSplitNoMergePU and
...
(Long ChangeLog diff - truncated)