Frank Winklmeier authored 5 years ago and Walter Lampl committed 5 years ago

Make `TrigFastTrackFinderMonitoring` compatible with GaudiConfig2 where
`self.name` is not directly writable anymore.

Stewart Martin-Haugh authored 5 years ago and Frank Winklmeier committed 5 years ago

Unused private data members.

Mark Sutton authored 5 years ago and Frank Winklmeier committed 5 years ago

These include several updates to the RegSelTool implementation with respect
to merge request !30981

Firstly better memory handling for the RegSelLUTCondData where the
payload is now stored using a unique_ptr to better avoid memory leaks.

Additionally there is an new class for the MDT_RegSelCondAlg which
uses the new MDT cabling conditions data to create the table for the
RegSelTool.

The RegSelToolConfig.py now has an improved private builder function,
whoch is used to provide public builders for the Pixel, SCT, TRT and MDT.

The SCT Cabling conditions data are now used for the EventIDRange for
the SCT table, rather than using the pixel cabling.

Some of the old RegSelSvc code has been retained, but commented since
we are still developing.

One additional factor regarding the MDT table creation code: The
createTable() method is essentially a cut and past of the original
MDT code from the MDT_RegionSelectorTable class. I did not originally
write this code, and don't want to touch it as that would require a
great deal of validation beyond the scope of the changes for this
merge request. There are a good many places where that code itself
could be improved, but that should be left for the Muon developers
for a later day.

For this code we are implementing the framework to provide the full
functionality for the new RegSelTool implementation so there will be
quite a lot of copying of code from the older implementation over
the coming weeks for the additional Muon and Calorimeter tables.

This includes all the fully functional changes for the new conditions data access
RegSelTool access to replace the egregious old RegSelSvc class

New classes are included:
```
   * RegSelCondData    a generic wrapper class for conditions data
   * RegSelLUTCondData the specific instance of the above wrapper for the RegSelSiLUT
                        conditions data for the ID And MS lookup tables
   * SiRegSelCondAlg    the new conditions algorithms to add the conditions data
```
Modifications are also included for the FastTrackFinder and the
TrigSpacePointConversionTool to replace the use of the RegSelSvc for the Pixel and
SCT in the SpacepointConversion tool by way of example - it is not a full replacement
in this package.

New configuration functions are provided in
```
	RegSelToolConfig.py
```
such that components can include the relevant RS tools using fragments such as
```
  from RegionSelector.RegSelToolConfig import makeRegSelTool
  spTool.RegSel_Pixel = makeRegSelTool("Pixel")
  spTool.RegSel_SCT   = makeRegSelTool("SCT")
```
The setup functions register the corresponding conditions algorithms when called
ensuring that they are registered once, and once only.

The code to use the RegSelSvc in this tool has been retained, but has been commented
out, since this change is still very much ongoing. The cleanup to remove this older
code will come along with the full replacement of the RegSelSvc in the full package
(and others) once the remaining RegSelTool developments are more complete.

Changes for the TRT and Muon Spectrometer region selector code will come once these
initial changes have been merged.

- implemented switch between run-2 and run-3 (ATR-20305)
- unified histo folder names (ATR-20305)
- fixed z-finder timer for non z-finder algos (ATR-20305)
- timer monitor change to milliseconds (ATR-20883)

Setting up the late muon trigger to run on out of time RoIs (produced by TrigmuRoI). Also configuring the data decoding and ID tracking to run in these RoIs (this required some modification on the decoding configuration, and a new instnce of the fast track finder).
The chain now runs in a full scan RoI mode, then creates the out of time RoIs then runs the data decoding, ID tarcking, and late muon reconstruction in one step (ATR-17553).

Susumu Oda authored 5 years ago and Adam Edward Barton committed 5 years ago

Add ATLAS_CHECK_THREAD_SAFETY. Add ATLAS_THREAD_SAFE to m_cache and m_layerVectors[3]. Change file mode to 644.

Savanna Shaw authored 6 years ago and Adam Edward Barton committed 6 years ago

Includes proper configuration of EF muon isolation algorithm and hypo,
setup of proper sequence to run ID tracking around muons and calculate the
isoltion, and addition of the relevant pieces to the menu.

(this monitoring, which is time consuming, is then not needed in the "standard FTK chains )
Menu changes to include this in beamspot_idperf chain and a new beamspot_mon chain.

Update packages:TrigFastTrackFinder TrigL2SiTrackFinder TrigL2TRTSegFinder TrigT2BeamSpot TrigTRTHighTHitCounter TrigInDetAnalysis TrigInDetAnalysisExample TrigInDetAnalysisUser TrigInDetAnalysisUtils TrigInDetTruthAlgs TrigInDetEvent TrigInDetEventTPCnv TrigInDetPattRecoEvent TrigIDJpsiMonitoring TrigIDTPMonitor TrigIDtrkMonitoring IDScanHitFilter IDScanZFinder TrigIDUtils TrigInDetPattRecoTools TrigInDetRecoTools TrigInDetToolInterfaces TrigInDetTrackExtrapolator TrigInDetTrackFitter TrigInDetVxInJetTool TrigJPsiTools TrigOfflineDriftCircleTool TrigOnlineSpacePointTool TrigSiSpacePointTool TrigTRT_TrackExtensionTool TrigVertexFitter TrigVKalFitter TrigInDetTruthEvent TrigTruthEventAthenaPool TrigTruthEventTPCnv TrigInDetValidation TrigInDetValidationLight TrigInDetValidationWeb  from upstream/21.0-TrigMC to upstream/master via pseudo-merge


Former-commit-id: 9e323acc

TrigUpgradeTests and TriggerRelease/runHLT_standalone tests to run again


Former-commit-id: 4aaa10ce

Susumu Oda authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: a4c91051

Former-commit-id: 71063ad6

Former-commit-id: 575796be

Stewart Martin-Haugh authored 8 years ago and Tim Martin committed 7 years ago

21.0 bjetbphys - CPU related savings for bjets and bphysics

See merge request !635

Former-commit-id: 0322c57c

	* tag TrigFastTrackFinder-00-01-73
	* python/TrigFastTrackFinder_Config.py - forgot to actually add the new histos here

	* tag TrigFastTrackFinder-00-01-72
	* Changes to allow use of FTK vertices in z-finding
	* Add residual plots per layer for pixels

2016-10-10 Dmitry Emeliyanov <D.Emeliyanov@rl.ac.uk>
	* tag TrigFastTrackFinder-00-01-71
	* new cut to support the "merge-sort" seed making

2016-09-23 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-70
	* MT update

2016-09-16 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-69
	* MT update

2016-09-01 Stewart Martin-Haugh <smh -at- cern -dot- ch>
...
(Long ChangeLog diff - truncated)


Former-commit-id: 1225d171

	* tag TrigFastTrackFinder-00-01-63
	* Fix memory leak (not deleting vertexCollection) ATR-13912
	* Delete code for unused vertex-seeded mode

2016-02-29 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-62
	* Remove debug printout (ATR-13429)

2016-02-15 Dmitry Emeliyanov <D.Emeliyanov@rl.ac.uk>
	* TrigFastTrackFinder-00-01-61
	* configured separate instance of TrigL2LayerNumberTool for FTF -- fixes for ATR-13396 and ATR-13401

2016-02-12 Dmitry Emeliyanov <D.Emeliyanov@rl.ac.uk>
	* TrigFastTrackFinder-00-01-60
	* using the new layer numbering scheme

	* python/TrigFastTrackFinder_Config.py (TrigFastTrackFinderBase.__init__):
	run ROTcreator temporarily, for ATR-12226 together with
	InDetTrigRecExample-00-11-65
	* tagged as TrigFastTrackFinder-00-01-59

	*  tag TrigFastTrackFinder-00-01-58

	*  tag TrigFastTrackFinder-00-01-57
	* don't configure unneeded tools for FTK instance

2015-12-17 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-57
	* Properly turn off residual monitoring in all slices except muon -
	calculations were still running (ATR-13081)

2015-12-09  Jiri Masik  <jiri.masik@manchester.ac.uk>

	* fix a problem with the previous tag, tagged as
	TrigFastTrackFinder-00-01-56

	* python/TrigFastTrackFinder_Config.py (TrigFastTrackFinderBase.__init__):
	run HoleSearch for tauCore to allow better track quality
	selection, tagged as TrigFastTrackFinder-00-01-55
	(TrigFastTrackFinderBase.__init__):

2015-12-03  Jiri Masik  <jiri.masik@manchester.ac.uk>
...
(Long ChangeLog diff - truncated)

	* python/TrigFastTrackFinder_Config.py: change from FTKrefit to FTKRefit

2015-11-16  John Baines  <john.baines@stfc.ac.uk>

	* python/TrigFastTrackFinder_Config.py: Update for TrigFTK_DataProviderSvc_Config moved to  TrigFTK_RecExample

2015-10-22  John Baines  <john.baines@stfc.ac.uk>

	* src/TrigFastTrackFinder.cxx: fix to get npix and nsct for TrigInDetTrack from FTK tracks.
	*  tag TrigFastTrackFinder-00-01-51

2015-10-14 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-50
	* Configuration for disabling TrigInDetTrack

	* python/TrigFastTrackFinder_Config.py: fix missing brem setting
	of trackMaker, tagged as TrigFastTrackFinder-00-01-49

2015-09-30 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-48
	* Remove unused members (Coverity 29880, ATR-9327)

2015-09-08  John Baines  <john.baines@stfc.ac.uk>

	* python/TrigFastTrackFinder_Config.py: remove type remapping for FTK instance
	(TrigFastTrackFinderBase.__init__): remove print

2015-09-03  Jiri Masik  <jiri.masik@manchester.ac.uk>

	* python/TrigFastTrackFinder_Config.py: brem aware instance of the
	fitter in the electron instance, tagged as
	TrigFastTrackFinder-00-01-45

	* tag TrigFastTrackFinder-00-01-44
	* Optionally disable track residual monitoring

2015-07-24  John Baines  <john.baines@stfc.ac.uk>

	* tag TrigFastTrackFinder-00-01-43
	* Add FTK and FTKrefit configurations - uses TrigFTK_DataProvider to get tracks with/wo refit

2015-07-13 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-42
	* Integrate Ondrej's changes for turning off clone removal for electrons

2015-07-07 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-41
	* Increase dR between doublets and increase radial bin size (work towards
	ATR-11470 on behalf of Dmitry)

2015-06-29 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-40
	* Turn off phi filtering for spacepoints in muon slice, improve large d0
...
(Long ChangeLog diff - truncated)

	* tag TrigFastTrackFinder-00-01-29
	* Fix q/p==0 protection, cleanup

2015-03-10 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-28
	* Fix floating point overflow by re-ordering multiplication (ATR-10471)

2015-03-03 Stewart Martin-Haugh <smh -at- cern -dot- ch>
	* tag TrigFastTrackFinder-00-01-27
	* Extra monitoring histograms