Savanna Shaw authored 4 years ago and Adam Edward Barton committed 4 years ago

Adding the L2 combined muon step to the trigger new JO test (ATR-20242). The step runs:
- A view data verifier to pick up the L2 SA muons from the previous step
- The ID fast track finding
- the muComb algorithm

Currently it seems that the combined electron+muon chains need to have the same number of steps for electrons and muons, so I split the muon chains into two type. The default chains (used in combination with other signatures) run the L2 SA and combined steps, and the msonly chains run the L2 SA and precision SA steps (and the L2 combined and preicion SA steps are only created for the relevant chains).

Updating a bit the muon trigger for the newJO test (ATR-20388):
- Updating some parts of the configuration for muon candidate builiding to be more appropriate for the trigger use case
- Setting up the ID geometry so we can extrapolate muons through the full detector
- Adding the EF MS hypo to replace the fake hypo

Adding the building of muoncandidates and xAOD muons for the SA part of the muon trigger in the new JO test. In principle this lets us run ms-only type chains in the new configuration (or will once I add a sensible hypo in the future).
- Made some changes in the configuration to various tools for trigger running
- Added configuration for alg to convert MS tracks to xADO trackParticles (temporarily in trigger config)
- Updated trigger configuration to call muon candidate and creator algs

Part of the migration in ATR-20388

Removing some data from the view data verifier because it is produced by algorithms already running in the view.

Aleksandra Poreba authored 4 years ago and Frank Winklmeier committed 4 years ago

Continue addition of combohypos to newJO menu generation. Also add
combohypos to cf and also partially to df. Integration will be
continued.

Re-enabling the MDT decoding for the new JO test:
- Commented out the MDT region selector tool definition, as this needs proper configuration for the new JO test. This introduces a warning for the MdtRdoToPrepData decoding, since the region selector tool is not defined (this is why the reference files for the decoding test is updated). However, without running the decoding at all, we can not run the trigger algorithmd, so is a slight improvement.
- This fixes the errors reported in ATR-21280

Also moved the decoding out of the L2SA job options. It needed to be updated to run inside the event views (otherwise we run into problems running the decoding multiple times in the full event when there is more than one RoI), and is not specific to L2SA, so was moved to the muon menu setup for now.

Savanna Shaw authored 4 years ago and Frank Winklmeier committed 4 years ago

This is a first attempt to add the MuonCombinedMuonCandidateAlg to the trigger newJO test. It's not quite working yet, so is added but commented out. Some modifications to the configuration does bring it closer to running:

- Added two new flags for the muon trigger: one general one that can cover the generic trigger configuration differences, and one SA muon specific flag since we configure some tools differently for SA muons than for combined muons in the trigger. Both flags are false outside of running the trigger.
- Fixed a small misconfiguration of one property for the CaloTrackStateOnSurfaceTool.
- Updated the configuration of several relevent tools for the trigger using the newly introduced flags.

Mark Andrew Owen authored 5 years ago and Frank Winklmeier committed 5 years ago

What I changed:
- JetChainConfiguration now represents the configuration of all the jet parts of the chain (e.g. j80_j60) rather than just a single leg.
- Because of this GenerateJetChainDefs no longer splits the chain defs.
- Similarly, in GenerateBjetChainDefs, the jet part of the chain is created from the unsplit chain def.
- The extractRecoDict function in JetRecoConfiguration now handles a vector of chain parts and checks the settings are consistent in the different parts.

Adding the track building for the muon trigger in the new JO test (ATR-20388):
- cloned the offline flags to set muon trigger specific values, and added the track builder as part of the muon trigger reco sequence
- migrated the tools in the muon seeded segment finder to be private
- removed a few instances of 'addPublicTool' where we can use private tools
- note that the region selector service used by the segment recovery is currently the default (which is correct at the moment), but this will probably need to be changed in the future, so keeping the property commented out for now.

Savanna Shaw authored 5 years ago and Walter Lampl committed 5 years ago

Starting to add the EF step for muon triggers in the new JO test (ATR-20388). At the moment have added the segment finding and a dummy hypo alg as the second step of the chain.

Shota Hayashida authored 6 years ago and Edward Moyse committed 6 years ago

Former-commit-id: cae95a79f9d807618f1e0dca1e65fb119633c801